Replies: 1 comment
-
I see this is actually documented in the 3.0 upgrade instructions despite being necessary for 2.10.5. I couldn't see any difference between wantProperties=True and wantProperties=False for the HttpStatusPush anyway. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I'm trying to clean up my deprecation warnings on 2.10.5 before upgrading to 3. The first one is
The arguments wantProperties passed to HttpStatusPush have been deprecated. Use generators instead
I've studied the documentation, and it's not at all clear to me what generators have got to do with wantProperties.
Looking at the code, it looks like this needs to be passed to the message formatter function passed to the generator, and the default on the MessageFormatterBase is wantProperties=True anyway, although the default on the HttpStatusPush was False.
So in 3.0 I could just remove the parameter and the default is true, but in 2.10.5 the default is still false and I would need to explicitly pass a generator in order to change it. Is that right?
Beta Was this translation helpful? Give feedback.
All reactions