Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The pre push script doesn't always stop the servers #305

Open
GentlemanHal opened this issue Feb 13, 2020 · 1 comment
Open

The pre push script doesn't always stop the servers #305

GentlemanHal opened this issue Feb 13, 2020 · 1 comment
Labels
bug Something isn't working as expected for developers Changes that make development easier help wanted Changes the team requires more information or help to resolve

Comments

@GentlemanHal
Copy link
Member

GentlemanHal commented Feb 13, 2020

Bug report

Expected behaviour?
Once the ./pre-push.sh has finished running the Nevergreen server and the CCTray XML mock server should no longer be running.

Actual behaviour?
Sometimes the servers (possibly just the CCTray XML mock server) are still running and attempting to run the develop script or pre push again results in an error when they try to start the servers again.

Steps to reproduce?

  1. Not sure

I think it might happen if the journey tests fail ⁉️

@GentlemanHal GentlemanHal added bug Something isn't working as expected for developers Changes that make development easier labels Feb 13, 2020
@GentlemanHal GentlemanHal added the help wanted Changes the team requires more information or help to resolve label Nov 14, 2022
thesheps added a commit to thesheps/nevergreen that referenced this issue Jan 12, 2023
@GentlemanHal
Copy link
Member Author

GentlemanHal commented May 9, 2024

I think the best approach for this is to make better use of npm scripts and tools such as concurrently

My comment from the PR:

If this was a pure node project we'd be making better use of npm commands and tools like concurrently. We didn't originally as it's a mixed repo and the client used to be quite simple. Now the client is much more complex and most features are client side nowadays.

So treating it like a node project and doing more via npm would probably make sense to most people contributing. I'm assuming we can easily call lein via npm to build/run/test/etc the server side stuff? 🤔

I wondering if this would be more reliable/easier than bash scripts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected for developers Changes that make development easier help wanted Changes the team requires more information or help to resolve
Projects
None yet
Development

No branches or pull requests

1 participant