-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The pre push script doesn't always stop the servers #305
Comments
…processes belonging to parent pid
I think the best approach for this is to make better use of npm scripts and tools such as concurrently My comment from the PR:
|
Bug report
Expected behaviour?
Once the
./pre-push.sh
has finished running the Nevergreen server and the CCTray XML mock server should no longer be running.Actual behaviour?
Sometimes the servers (possibly just the CCTray XML mock server) are still running and attempting to run the develop script or pre push again results in an error when they try to start the servers again.
Steps to reproduce?
I think it might happen if the journey tests fail⁉️
The text was updated successfully, but these errors were encountered: