-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Need investigation] Huge memory leak? #3992
Labels
Comments
kikuomax
changed the title
[Need more info] Huge memory leak?
[Need investigation] Huge memory leak?
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@kikuomax Good that you pointed that out. Yes, actually we use Memlab to gauge heap size and memory leaks in applications. Memlab requires us to write a scenario file as mentioned in their documentation. I created a scenario file for this project as well. Sadly currently memlab has a limitation of a protocolTimeout error for some cases, this one falls into that. I have reported the issue, they are working to fix within this week. After that I will attach the memory footprint results before and after the leak fixes in this project.
I heard back from Memlab developer regarding the timeout and page crash issue I was facing when executing their tool on the scenario file I wrote for Buefy.
This is what their developer has to say:
The code patterns fixed in this PR are some of the common sources of memory leaks, as per our research on Github and StackOverflow history. Nevertheless, if I manage to resolve the Memlab crash issue and provide concrete heap/leak reduction after these fixes, I will let you know as soon as is possible..
TBH It's a pretty normal scenario file that follows puppeteer syntax, similar to what I have been using for multiple other projects 🤔 . I have attached it here for reference:
test-scenario-buefy.js.zip
Originally posted by @Arooba-git in #3991 (comment)
The text was updated successfully, but these errors were encountered: