Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilities issue #16

Open
garyhlai opened this issue Jan 3, 2019 · 1 comment
Open

Vulnerabilities issue #16

garyhlai opened this issue Jan 3, 2019 · 1 comment

Comments

@garyhlai
Copy link

garyhlai commented Jan 3, 2019

screen shot 2019-01-03 at 5 45 41 pm

There are two vulnerabilities issues. "Missing Origin Validation" and "Command Injection." If I try to fix them by running "nom install --save-dev [email protected]" it will break the code. Help please?

@btmills
Copy link
Owner

btmills commented Jan 5, 2019

The good news is that the published react-datamaps package doesn’t depend on webpack-dev-server at all. It’s just the examples, which don’t get published, that use the old version. That also makes this much less severe since the vulnerability won’t be part of any production system. If you’re interested in fixing this, I’d welcome a pull request that upgrades the examples to use the latest webpack and webpack-dev-server!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants