-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One in 128 accounts are not BIP-32 compatible #719
Comments
I think instead, any wallet that needs to be compatible with seed phrase import using the wallet's non-default derivation needs to change. In other words, wallets that try to support (the imo ill advised) "import any seed into the wallet" need to be made aware of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is due to btcsuite/btcutil#172.
When the leading byte of a derived extended private key is zero, all of that key's children are not BIP-32 compatible. There are two opportunities for this to happen in a BIP-44 derivation path, so the incidence rate is 1 in 128.
btcsuite/btcutil#182 corrects this issue, but affected wallets have to be migrated and/or the user notified. The function
ExtendedKey.IsAffectedByIssue172
is provided for detection of the issue.The text was updated successfully, but these errors were encountered: