New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Circular deps between btcutil and btcd, and tons of duplicated deps with different versions because the versions are inconsistent #2127
Comments
(All things aside) what was the thing you were trying to do? Maybe I could help out there. btcd's main package isn't really meant for outside usage, each of the individual packages are. |
We're aware of that. Still looking for reviewers of #1825. |
We are using it in a few projects and I noticed that I could not get rid of the many duplicated deps and wondered why.
Why not? It's a perfectly usable library. I make use of the Nested modules are kind of confusing and seem hard to maintain anyway, seems more natural to just make it a package - would there be a downside to that? |
Not much besides that it's just been like that.
Not that I can think of. |
Start a new project
go mod init foo
, thengo get github.com/btcsuite/btcd
, then add amain.go
The reason is that for example,
[email protected]
references[email protected]
:btcd/go.mod
Line 5 in d55c55a
while btcutil in turn references
[email protected]
https://github.com/btcsuite/btcd/blob/d55c55a81f8f9cf2b0fa3cbb83e820ea28173081/btcutil/go.mod#L7C1-L7C64
which in turn references an older btcutil, and so on.
Not sure if there are more such instances.
I am unsure why btcutil is a module of its own, can't it just be a package inside btcd and not a module?
If it has to be a module, btcutil and btcd should ideally not depend on each other.
Barring all of that, the two should point to the same versions.
The text was updated successfully, but these errors were encountered: