Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Testing: Paid Invoice, Pull Payment, Create Invoice: Tested on Windows #4986

Open
mouxdesign opened this issue May 18, 2023 · 12 comments · May be fixed by #5452
Open

Accessibility Testing: Paid Invoice, Pull Payment, Create Invoice: Tested on Windows #4986

mouxdesign opened this issue May 18, 2023 · 12 comments · May be fixed by #5452
Assignees
Labels
Enhancement Improvements to an existing feature good first issue UI / UX Front-end issues, for front-end designers
Milestone

Comments

@mouxdesign
Copy link

Hey team,

Thanks for joining us today on the accessibility kick off call. Tested the following screens:

  • Paid Invoice
  • Pull Payment
  • Create Invoice

Pretty much just enabled the voice over feature for windows and tested by clicking on various aspects of the UI.
Video walkthrough of how it was tested here; https://www.loom.com/share/eb2c9eb030f24528a3dbc3e14abb01ad

I used some blue and yellow color coding so that it's a quick and easy reference. Most items were labelled, just a few items here and there where it might be helpful to edit or add in labels. Hope this is helpful and if there's any questions feel free to ask.

Group 3

Group 1 (4)
Group 2 (4)

@Bas02 Bas02 added Bug UI / UX Front-end issues, for front-end designers good first issue labels May 18, 2023
@pavlenex pavlenex added Enhancement Improvements to an existing feature and removed Bug labels May 19, 2023
@pavlenex
Copy link
Contributor

Thanks for posting this @mouxdesign!

We'd go through video and log these issues as a task-list here, then proceed with tackling them
cc @Bas02 & @petzsch

@Fahadshahzad797

This comment was marked as spam.

@Fahadshahzad797

This comment was marked as spam.

@Spenda9

This comment has been minimized.

@dennisreimann
Copy link
Member

@mouxdesign Can you elaborate on what it means that a label is missing or needs improvement? For instance, how would the "Paid invoice" screen be improved and what needs to be changed in terms of HTML? If you could provide a link for guidance, that would also be fine — I'm just struggling to see what needs to be changed concretely, as the spots you marked seem to be "labels" already.

@dennisreimann
Copy link
Member

@mouxdesign Can you help me understand what to do exactly? (See my previous comment)

@pavlenex Let's put this into the backlog until we clarify the actual TODOs.

@TChukwuleta TChukwuleta linked a pull request Nov 6, 2023 that will close this issue
@mouxdesign
Copy link
Author

Sure!

The labels on the paid invoice screen as an example:

Labels are the way that the screen reader would read the text to a blind/visually impaired person.

On the invoice paid screen:
The label for Invoice ID would read Invoice ID. This is the aria label on the html side of things.

using-aria-label-identif-89ed5dcc8c595

So its pretty much ensuring that those aria labels are relevant and directly connected to the text there itself.

Imagine that a person cannot see the text on the screen so when they hover over each element, the element itself reads out very succiently what it is.

  • View reciept: The aira text would read "view reciept"
  • Return to developer wallet: The aria text would read "return to developer wallet"

Hope this is helpful, feel free to shoot over any questions will do my best to help! If you like feel free to send a screen shot of the html of for example the paid invoice screen and then together we can look at the labels.

@dennisreimann
Copy link
Member

@mouxdesign Thanks for answering!

grafik

Invoice ID

Let's take the Invoice ID as an example:

<div>
    <dt>Invoice ID</dt>
    <dd>9AgMUeAYBJbSt3xxcHGdSV</dd>
</div>

There the connection between the label and content isn't clear, so it would turn into this?

<div>
    <dt id="dt_invoice_id">Invoice ID</dt>
    <dd aria-labelledby="dt_invoice_id">9AgMUeAYBJbSt3xxcHGdSV</dd>
</div>

"Return to" button

For the buttons it isn't clear to me what is missing, because there the connection between the element and descriptive text is present imho, because it's the elements content — what am I missing?

<div class="buttons">
    <a href="/i/DPJKnfjFPJ74SrQcxKAmJ/receipt" id="ReceiptLink" class="btn btn-primary rounded-pill w-100">View receipt</a>
    <a href="https://satoshisteaks.com/" id="StoreLink" class="btn btn-secondary rounded-pill w-100">Return to Satoshis Steaks</a>
</div>

@pavlenex pavlenex linked a pull request Nov 7, 2023 that will close this issue
@pavlenex
Copy link
Contributor

pavlenex commented Nov 7, 2023

@dennisreimann There's some work by @TChukwuleta done here #5452

@dennisreimann
Copy link
Member

@pavlenex I saw that, yet it doesn't address what's described here.

@TChukwuleta
Copy link
Contributor

Hello @dennisreimann

I made an update to the PR, for the different things that was pointed out in terms of accessibility and labelling.

Please kindly review.

@pavlenex pavlenex modified the milestones: 1.12.0, 1.12.x Dec 1, 2023
@mouxdesign
Copy link
Author

Just circling back to this one:

Invoice ID
9AgMUeAYBJbSt3xxcHGdSV

The aria label here would describe the text as best as possible to the user. So in this case "invoice id" would also be ok. The voice reader will read out "invoice id".

Then for the button labels.
The buttons would have their own additional labels called aria labels. Like this:
Screenshot 2024-02-02 125156

Would the text "view buttons" be readable there by a screen-reader? I am not a programmer and so hard to tell how a users device will read out the text. To my knowledge if the code does not contain the word "aria label" then the screen reader of the users computer does not recognize it as text that it should read out. Hope that makes sense.

@pavlenex pavlenex modified the milestones: 1.12.x, 1.13.x Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to an existing feature good first issue UI / UX Front-end issues, for front-end designers
Projects
Status: In Progress 🏗️
Development

Successfully merging a pull request may close this issue.

9 participants