Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update version of serialize-javascript in use by image dependencies #4008

Closed
russell-maz opened this issue Apr 17, 2024 · 3 comments
Closed

Comments

@russell-maz
Copy link

Describe the bug
The browserless container has mocha as a dependecy. Mocha depends on serialize-javascript version 6.0.0. There is a new version of serialize-javascript that addresses a vulnerability that appeared in our AWS container registry.

https://security.snyk.io/vuln/SNYK-JS-SERIALIZEJAVASCRIPT-6147607

To Reproduce
Steps to reproduce the behavior:

  1. Build latest container
  2. sh into container shell
  3. Run npm ls serialize-javascript
@browserless.io/[email protected] /usr/src/app
└─┬ [email protected]
  └── [email protected]

Expected behavior
Can we bump the version of serialize-javascript being used by depdencies to 6.0.2

Screenshots
image
image

@joelgriffith
Copy link
Collaborator

Once mochajs/mocha#5109 is fixed then we can get that fix internally. This dependency shouldn't be present or used in production systems and is only used during tests. Can you verify that this package isn't present in your container?

@russell-maz
Copy link
Author

Hi @joelgriffith

You actually raised a good question. I need to check something in the container. THis may not be for you to resolve. I will revert back shortly

Russell

@russell-maz
Copy link
Author

Closing this story, the issue is actually originating from a repo i push into my docker container, not your image. Apologies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants