Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buffer upgrades #187

Open
calvinmetcalf opened this issue Sep 13, 2019 · 3 comments
Open

buffer upgrades #187

calvinmetcalf opened this issue Sep 13, 2019 · 3 comments

Comments

@calvinmetcalf
Copy link
Contributor

seems like we're going to need to upgrade bn.js to deal with buffer depreciations see browserify/publicEncrypt#20 browserify/createECDH#13 browserify/browserify-sign#45 and browserify/diffie-hellman#31# which will all need to be upgraded in sync in order to make sure they all use the same major version of bn one

@fanatid
Copy link

fanatid commented Dec 23, 2019

Initial issue in elliptic repo: indutny/elliptic#191

@rawr51919
Copy link

rawr51919 commented Feb 2, 2021

This should be fixed in #200 because we switched to Buffer.from() there, but I'd like input on this. The others can also be easily fixed, or are already fixed. The only thing keeping all these from being officially fixed is for browserify/diffie-hellman#31 to have bn.js updated. May be thinking of superseding it due to inactivity though.

@rawr51919
Copy link

rawr51919 commented Feb 2, 2021

A dependency updater like Depfu would be nice to have to keep dependencies like bn.js updated so that way we don't have to worry about keeping them in sync, because that'll do it for us. It's probably something for another issue, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants