Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only support USD currency #267

Closed
junyuanz1 opened this issue Apr 24, 2023 · 3 comments
Closed

only support USD currency #267

junyuanz1 opened this issue Apr 24, 2023 · 3 comments
Labels
enhancement New feature or request Stale

Comments

@junyuanz1
Copy link
Contributor

junyuanz1 commented Apr 24, 2023 •
edited

Hi @brndnmtthws ,

I saw USD is hard coded in multiple different places. I want to help and make this currency optional.

The easiest solution would be user can create multiple configuration files for different currencies. If that sounds good, I can help implement this change.

Thanks,

Junyuan
@brndnmtthws brndnmtthws added the enhancement New feature or request label Apr 25, 2023
@brndnmtthws
Copy link
Owner

I'd be happy to add this feature, it just needs to be implemented such that it remains backward-compatible.

@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 365 days with no activity. Remove stale label or comment, or this issue will be closed in 30 days.

@github-actions github-actions bot added the Stale label Apr 25, 2024
@github-actions GitHub Actions
Copy link

This issue was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brndnmtthws @junyuanz1