Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

og:type detection appears to be incorrect #6

Open
olbrich opened this issue Dec 24, 2022 · 0 comments
Open

og:type detection appears to be incorrect #6

olbrich opened this issue Dec 24, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@olbrich
Copy link

olbrich commented Dec 24, 2022

{% if page.date %}
<meta property="og:type" content="article" />
<meta property="article:published_time" content="{{ page.date | date_to_xmlschema }}" />
{% else %}
<meta property="og:type" content="website" />
{% endif %}

When implementing this plugin using Bridgetown 1.1, this template always detects the page as an article. This appears to happen because all pages have a date property. As of the latest release of this plugin (5.0), it's not possible to properly set the og:type for pages that aren't articles.

I would expect this value to be set by the page front matter.. perhaps something like seo.type. This would also make it easy to set up defaults for particular page types using front-matter defaults.

@jaredcwhite jaredcwhite added enhancement New feature or request help wanted Extra attention is needed labels Jan 8, 2023
@jaredcwhite jaredcwhite self-assigned this Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants