Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to set "propagate_at_launch=true" on tags added to aws_autoscaling_group Terraform resources. #502

Open
danielgollas opened this issue Mar 29, 2024 · 1 comment
Labels
wontfix This will not be worked on

Comments

@danielgollas
Copy link

danielgollas commented Mar 29, 2024

Is your feature request related to a problem? Please describe.
We use tags to track costs across our infrastructure, linking them back to specific git_repos (using the git tags added by yor). However, EC2 instances launched through an AWS autoscaling group do not receive those tags (and can therefore not be tracked).
AWS autoscaling groups have the "propagate_at_launch" property that can be added to individual tag blocks in the aws_autoscaling_group module (but not in a plural "tags" mapping), causing the EC2 instances to get a copy of the specified tags from the autoscaling group.

Describe the solution you'd like
Adding tags to autoscaling group resources as individual "tag" blocks (instead of a "tags" mapping) and adding the option to set the "propagate_at_launch" property on them for the standard git tagger would be very useful for tracking dynamically created resources.

Describe alternatives you've considered
The workaround is to manually add a tag block to an autoscaling group resource with a static or derived value, without making use of Yor and the repository values it computes, but this is manual and error-prone work.

Additional context
Documentation for the propagate_at_launch tag: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/autoscaling_group#propagate_at_launch

Copy link

stale bot commented May 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant