Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CKV_AWS_94 should be updated to allow KMS mode: 'SSE-KMS-WITH-SERVICE-ROLE' #6237

Open
robotparty opened this issue May 3, 2024 · 1 comment
Labels
checks Check additions or changes

Comments

@robotparty
Copy link

Describe the issue
CKV_AWS_94 should be updated to allow KMS mode: 'SSE-KMS-WITH-SERVICE-ROLE'

AWS doc: https://docs.aws.amazon.com/glue/latest/dg/set-up-encryption.html

Examples

resource "aws_glue_data_catalog_encryption_settings" "this" {
  #checkov:skip=CKV_AWS_94:Chekov is not aware of the new KMS mode as of 05/2024
  # it isn't considering it valid: https://github.com/bridgecrewio/checkov/blob/master/checkov/cloudformation/checks/resource/aws/GlueDataCatalogEncryption.py
  data_catalog_encryption_settings {
    connection_password_encryption {
      aws_kms_key_id                       = data.aws_kms_key.artifacts.arn
      return_connection_password_encrypted = true
    }
    encryption_at_rest {
      catalog_encryption_mode         = "SSE-KMS-WITH-SERVICE-ROLE"
      catalog_encryption_service_role = var.role_arns.glue_catalog_encryption
      sse_aws_kms_key_id              = data.aws_kms_key.artifacts.arn
    }
  }
}

Version (please complete the following information):

  • Checkov Version 3.2.41

Additional context
Add any other context about the problem here.

@robotparty robotparty added the checks Check additions or changes label May 3, 2024
@mannycepeda1989
Copy link

Thank you for sharing your feedback on this issue, it does appear that Checkov does not have a Policy to check for this currently. Please feel free to create a Custom Check and share the information, you can also contribute your custom check for future consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checks Check additions or changes
Projects
None yet
Development

No branches or pull requests

2 participants