Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Praise: Very excited for the ti branch! #17

Open
amerkay opened this issue Dec 23, 2022 · 7 comments
Open

Praise: Very excited for the ti branch! #17

amerkay opened this issue Dec 23, 2022 · 7 comments

Comments

@amerkay
Copy link
Contributor

amerkay commented Dec 23, 2022

Hey @brian6091,

Awesome work! Best SD Colab notebooks out there are yours! Been playing around with them for a couple of weeks with LoRA.

Can't wait for the ti branch with config Colab to be ready :)

Let me know how I can help out.

@brian6091
Copy link
Owner

@amerkay
Glad you can follow given the rather uninformative commit messages!
Lots of changes coming up. I should have it ready for testing in a couple of days. Inference part still requires some work given the number of possibilities that have to be taken into account...

@amerkay
Copy link
Contributor Author

amerkay commented Dec 23, 2022

I can help with that. I had to modify the main branch notebook to "monkey patch" LoRA for inference.

Still wrapping my head around the embedding resizing for the TI method. Got a bunch of errors, but that might be because I was trying to speed things up with Flax/JAX code at the same time.

No rush! Great work, mate!

@brian6091
Copy link
Owner

Cool, I'll ping you when I get the training part finished. I'm waiting for the safetensors pull request to get merged into LoRA to decide exactly how to go about saving model bits.

@brian6091
Copy link
Owner

@amerkay

I can help with that. I had to modify the main branch notebook to "monkey patch" LoRA for inference.

Ah yes, I forgot to do that. I've tucked away the current main branch in v0.0.1 branch. If you want to make a pull request on that branch I'd appreciate that.

@amerkay
Copy link
Contributor Author

amerkay commented Dec 23, 2022

Ah yes, I forgot to do that. I've tucked away the current main branch in v0.0.1 branch. If you want to make a pull request on that branch I'd appreciate that.

You lost me :) Not much going on in v0.0.1 branch:
image

@brian6091
Copy link
Owner

Sorry, I just meant for the inference part that you had to add to the notebook on main

@amerkay
Copy link
Contributor Author

amerkay commented Dec 23, 2022

No worries - done, pull request at #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants