Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rate limiting #3

Open
yrliou opened this issue May 29, 2020 · 0 comments
Open

Add rate limiting #3

yrliou opened this issue May 29, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@yrliou
Copy link
Member

yrliou commented May 29, 2020

Tried to add the RateLimiter in the initial implementation but it turns out it does not fit sync-server use case and we would be throttled when doing normal sync flow, so it was removed.
We should come back on this topic and add rate limiting either in ALB or in our go-sync server application.
@yrliou yrliou added the enhancement New feature or request label May 29, 2020
@yrliou yrliou mentioned this issue May 29, 2020
Merged
DJAndries added a commit that referenced this issue May 14, 2024
@DJAndries
Merge pull request #255 from brave/master
4760ab9 
Release 05/13/2024 #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yrliou