Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Refactor purchase intent to listen for OnTabDidChange and OnDidOpenNewTab instead of OnTextContentDidChange #38493

Closed
tmancey opened this issue May 22, 2024 · 1 comment · Fixed by brave/brave-core#23787
Closed

[ads] Refactor purchase intent to listen for OnTabDidChange and OnDidOpenNewTab instead of OnTextContentDidChange #38493

tmancey opened this issue May 22, 2024 · 1 comment · Fixed by brave/brave-core#23787
Assignees
@tmancey
Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Milestone
1.68.x - Beta

Comments

@tmancey
Copy link
Contributor

tmancey commented May 22, 2024 •
edited

Description

[ads] Refactor purchase intent to listen for OnTabDidChange and OnDidOpenNewTab instead of OnTextContentDidChange because we do not require the text.
@tmancey tmancey self-assigned this May 22, 2024
@tmancey tmancey added this to Review in Ads May 22, 2024
@tmancey tmancey changed the title [ads] Refactor purchase intent to listen for OnTabDidChange instead of OnTextContentDidChange [ads] Refactor purchase intent to listen for OnTabDidChange and OnDidOpenNewTab instead of OnTextContentDidChange May 22, 2024
@tmancey tmancey mentioned this issue May 22, 2024
Merged
24 tasks
Ads automation moved this from Review to Done May 26, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 26, 2024
@btlechowski
Copy link

Verified with

Brave 1.68.94 Chromium: 126.0.6478.114 (Official Build) beta (64-bit)
Revision 8981faf58380240eab6e999e6bf06f9ed9314336
OS Linux

Verified test plan from brave/brave-core#23787

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Status: Done
Ads
  
Done
Milestone
1.68.x - Beta
3 participants
@tmancey @btlechowski @brave-builds