Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.navigator.onLine always returns false #38240

Open
piperone opened this issue May 10, 2024 · 0 comments
Open

window.navigator.onLine always returns false #38240

piperone opened this issue May 10, 2024 · 0 comments

Comments

@piperone
Copy link

Description

Sometimes, particularly in a PWA context, it is necessary to check if the user has an active internet connection. This is easily achieved in other browsers by simply checking the value of window.navigator.onLine. In Brave, this value is always false.

This could very well be intentional, but I don't see how removing this enhances user security or anything like that.

Steps to Reproduce

  1. Open the console on any page
  2. Type "window.navigator.onLine" or "navigator.onLine"
  3. The value returned should is false

Actual result:

The value false is returned

Expected result:

The value true should be returned when the user has an internet connection

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

1.65.130 Chromium: 124.0.6367.159 (Offisiell delversjon) (arm64)

Version | 67843557ad274aba4b206391773c789c174b7fad
OS | macOS Version 14.4.1

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Unknown
  • Can you reproduce this issue with the nightly channel? Unknown

Other Additional Information:

Issue present regardless of Brave Shields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant