Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to Brave notification is not shown upon initial install of Brave #38233

Closed
MadhaviSeelam opened this issue May 10, 2024 · 4 comments · Fixed by brave/brave-core#23587
Closed

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented May 10, 2024

Description

Found while testing #26301 in 1.66.104. Would you like to pin Brave to your taskbar? notifications were shown in 1.67.59 when this issue was originally tested. Failed to get notifications in 1.67.78 beta and 1.68.2 nightly on initial installs as well. However, notifications are received during first install of current release.

Steps to Reproduce

  1. Install 1.66.104
  2. launch Brave

Actual result:

Would you like to pin Brave to your taskbar? notification is not shown

Expected result:

image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.66.104 Chromium: 125.0.6422.41 (Official Build) (64-bit)
-- | --
Revision | 6213f85e37bb676772fb221ce11a41c2b1be0fe2
OS | Windows 11 Version 23H2 (Build 22631.3527)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @simonhong
cc: @brave/qa-team

@MadhaviSeelam
Copy link
Author

Verification PASSED using

Brave | 1.68.12 Chromium: 125.0.6422.41 (Official Build) nightly (64-bit)
-- | --
Revision | 52fd85161e2ad348a6a1518a4c980d5d84d7067e
OS | Windows 11 Version 23H2 (Build 22631.3527)

Case 1: New Install: Pin to taskbar

  1. Installed 1.68.102
  2. launched Brave
  3. clicked Yes
  • Confirmed `Would you like to pin Brave Nightly to your taskbar? Notification is shown upon initial install
  • Confirmed Brave is already pinned text shown in brave://settings/getStarted
example example
image image

Case 2: New Profile: Do not pin to taskbar

  1. continue from Case 1
  2. deleted existing profile
  3. launched Brave
  4. clicked No
  • Confirmed `Would you like to pin Brave Nightly to your taskbar? Notification is shown upon launch of a new profile
  • Confirmed Pin button is shown in brave://settings/getStarted
example example
image image

@kjozwiak
Copy link
Member

The above requires 1.66.108 or higher for 1.66.x verification 👍 Removing the QA Pass as we'll need to re-verify the above using 1.66.x. However, used #38233 (comment) as the needed verification on Nightly for the 1.66.x uplift as per brave/brave-core#23626 (review).

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.66.108 Chromium: 125.0.6422.41 (Official Build) (64-bit)
-- | --
Revision | 3a79189ba4e3cf17c382dd265d4f447f83a8f49d
OS | Windows 10 Version 22H2 (Build 19045.4291)

image

@stephendonner
Copy link

stephendonner commented May 15, 2024

Verified PASSED using

Brave | 1.66.108 Chromium: 125.0.6422.41 (Official Build) (64-bit)
-- | --
Revision | 3a79189ba4e3cf17c382dd265d4f447f83a8f49d
OS | Windows 10 Version 22H2 (Build 19045.4412)

Case 1: New Install: Pin to taskbar

  • installed 1.66.108
  • launched Brave
  • clicked Yes

Confirmed Would you like to pin Brave Nightly to your taskbar? notification is shown upon initial install

Confirmed Brave is already pinned text shown in brave://settings/getStarted

example example example
image image image

Case 2: New Profile: Do not pin to taskbar

  • continue from Case 1
  • deleted existing profile
  • launched Brave
  • clicked No

Confirmed Would you like to pin Brave to your taskbar? notification is shown upon launch of a new profile

Confirmed Pin button is shown in brave://settings/getStarted

example example example
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants