Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in AddSwitchChainNetworkFragment #38218

Closed
SergeyZhukovsky opened this issue May 10, 2024 · 0 comments · Fixed by brave/brave-core#23645
Closed

Crash in AddSwitchChainNetworkFragment #38218

SergeyZhukovsky opened this issue May 10, 2024 · 0 comments · Fixed by brave/brave-core#23645
Assignees
Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include

Comments

@SergeyZhukovsky
Copy link
Member

I found that crash in Google Play Console on nightly 1.67.76. It's fine to just fix it in master as we don't have a lot of them.

Exception org.chromium.base.JniAndroid$UncaughtExceptionException:
  at org.chromium.base.JniAndroid$UncaughtExceptionException.<init> (JniAndroid.java:49)
  at org.chromium.base.JniAndroid.handleException (JniAndroid.java:89)
  at android.os.MessageQueue.nativePollOnce
  at android.os.MessageQueue.next (MessageQueue.java:325)
  at android.os.Looper.loop (Looper.java:142)
  at android.app.ActivityThread.main (ActivityThread.java:7000)
  at java.lang.reflect.Method.invoke
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:441)
  at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1408)
Caused by java.lang.ArrayIndexOutOfBoundsException: length=0; index=0
  at org.chromium.chrome.browser.crypto_wallet.fragments.dapps.AddSwitchChainNetworkFragment.lambda$fetchNetworkInfo$5 (AddSwitchChainNetworkFragment.java:184)
  at org.chromium.brave_wallet.mojom.JsonRpcService_Internal$JsonRpcServiceGetPendingAddChainRequestsResponseParamsForwardToCallback.accept (JsonRpcService_Internal.java:2835)
  at org.chromium.mojo.bindings.RouterImpl.handleIncomingMessage (RouterImpl.java:222)
  at org.chromium.mojo.bindings.RouterImpl$HandleIncomingMessageThunk.accept (RouterImpl.java:29)
  at org.chromium.mojo.bindings.Connector.readAndDispatchMessage (Connector.java:194)
  at org.chromium.mojo.bindings.Connector.readOutstandingMessages (Connector.java:159)
  at org.chromium.mojo.bindings.Connector.onWatcherResult (Connector.java:137)
  at org.chromium.mojo.bindings.Connector$WatcherCallback.onResult (Connector.java:128)
  at org.chromium.mojo.system.impl.WatcherImpl.onHandleReady (WatcherImpl.java:60)
@SergeyZhukovsky SergeyZhukovsky added crash priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels May 10, 2024
@SergeyZhukovsky SergeyZhukovsky added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels May 10, 2024
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/include
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants