Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Network Prop from Create Placeholder Icon Component #38217

Closed
Douglashdaniel opened this issue May 10, 2024 · 0 comments · Fixed by brave/brave-core#23603
Closed

Remove Network Prop from Create Placeholder Icon Component #38217

Douglashdaniel opened this issue May 10, 2024 · 0 comments · Fixed by brave/brave-core#23603
Assignees
@Douglashdaniel
Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/exclude
Milestone
1.68.x - Nightly

Comments

@Douglashdaniel
Copy link

Description

The Network prop in the CreatePlaceholderIcon component is depreciated and needs to be removed.

https://github.com/brave/brave-core/blob/master/components/brave_wallet_ui/components/shared/create-placeholder-icon/index.tsx#L57-L61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
dev-concern feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA/No release-notes/exclude
Projects
Web3
Status: Done
Milestone
1.68.x - Nightly
Development

Successfully merging a pull request may close this issue.

chore(wallet): Remove Deprecated Network Prop brave/brave-core
2 participants
@Douglashdaniel @brave-builds