Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add current tab shows blue and black backgrounds in the bookmarks & reading list side panel #38202

Open
MadhaviSeelam opened this issue May 9, 2024 · 1 comment
Open

Add current tab shows blue and black backgrounds in the bookmarks & reading list side panel #38202

MadhaviSeelam opened this issue May 9, 2024 · 1 comment
Assignees
@simonhong
Labels
bug design A design change, especially one which needs input from the design team OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes

Comments

@MadhaviSeelam
Copy link

Description

Add current tab in the bookmarks & reading list side panels show blue background and black ground respectively in 1.66.104. However, Add current tab button in 1.67.78 (beta) shows correct background with light theme.

Steps to Reproduce

  1. Installed 1.66.104
  2. launched Brave
  3. enable sidebar
  4. click bookmarks button
  5. click reading list button

Actual result:

Add current tab button show blue background in the bookmarks sidepanel
Add current tab button show black background in the readinglist sidepanel

bookmarks reading list
image image

Expected result:

bookmarks reading list
image image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.66.104 Chromium: 125.0.6422.41 (Official Build) (64-bit)
-- | --
Revision | 6213f85e37bb676772fb221ce11a41c2b1be0fe2
OS | Windows 11 Version 23H2 (Build 22631.3527)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? No

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @aguscruiz
cc: @brave/qa-team
@MadhaviSeelam MadhaviSeelam added OS/Desktop bug QA/Yes design A design change, especially one which needs input from the design team labels May 9, 2024
@MadhaviSeelam MadhaviSeelam changed the title Add current tab shows background blue and backgrounds in the reading list & bookmarks sidepanel Add current tab shows blue and black backgrounds in the bookmarks & reading list side panel May 9, 2024
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label May 9, 2024
@simonhong simonhong self-assigned this May 10, 2024
@simonhong
Copy link
Member

simonhong commented May 10, 2024 •
edited

In 1.66.x, there is no leo-button but in 1.68.x, leo-button is used
1.66.x
Screenshot 2024-05-10 at 10 53 24
1.68.x
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug design A design change, especially one which needs input from the design team OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rebron @simonhong @MadhaviSeelam