-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split pull-request #94 into smaller parts #116
Labels
Comments
Marked this as completed:
As it has been implemented in v1 as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Pull request #94 has some nice feature implementations.
In its current state, however, the PR has too many changes to be merged all at once.
To make it possible to split the workload, separate pull-request should be created (based on the code in #94) for the following features:
The order of these items is currently semi-random.
bpkg-logging
scriptbpkg_error
,bpkg_info
,bpkg_message
,bpkg_warn
are moved fromlib/utils/utils.sh
bpkg_debug
is newly addedbpkg-utils-url
script with generic URL functions.I don't think specific functions like
bpkg_is_coding_net
belong here but that could be discussed.bpkg uninstall
commandBPKG_LOG_LEVEL
instead ofLOG_LEVEL
BPKG_PKG_PREFIX
to overwrite default deps dirAfter such changes have been made/merged the remainder of the functionality can be discussed.
To make it clear, all of this does not have to be done by original author. Anyone can pick up (parts of) the workload to move things forward.
The text was updated successfully, but these errors were encountered: