Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker-compose): run jackson service #1735

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MissaDavid
Copy link

What does this PR do?

This PR intends to facilitate the deployment of the Jackson service, using docker compose. I transferred the docker command provided in the documentation into a generic docker compose file. I'm not sure what makes the most sense regarding the DB settings, so for now I have only added the Postgres env variables.

Fixes #61 (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How should this be tested?

  1. Start your postgres DB
  2. In your root folder, run:
docker compose up

This should create a container named jackson, running on port 5225.
3. The service is accessible at the following address: http://localhost:5225/. And if you go to http://localhost:5225/api/health, it will return your current version of Jackson (for me it was {version: "1.13.0"}).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ghost
Copy link

ghost commented Oct 8, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@devkiran devkiran requested a review from a team October 10, 2023 06:27
@MissaDavid
Copy link
Author

Hi @devkiran, I left a comment on the issue to get more detailed ACs from you, but I can open this PR for review and leave it as is if you think that's already a good start. Let me know your preference!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy Jackson using docker-compose
1 participant