Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out if pushbackreader optimization by @chrisn helps #100

Open
borkdude opened this issue May 1, 2023 · 3 comments
Open

Figure out if pushbackreader optimization by @chrisn helps #100

borkdude opened this issue May 1, 2023 · 3 comments

Comments

@borkdude
Copy link
Owner

borkdude commented May 1, 2023

Port by @slipset: https://github.com/slipset/data.json/commits/with-char-reader
@chrisn: https://github.com/cnuernber/charred/blob/master/java/charred/CharReader.java#L82

I don't know if clojure code needs to push back more than one character, I guess we'll figure out by trial and error, so let's be very careful before we use this in anything production.

@slipset
Copy link
Sponsor

slipset commented May 1, 2023

That's the wrong chrisn, you're looking for @cnuernber

@borkdude
Copy link
Owner Author

borkdude commented May 1, 2023

Whoops, sorry :)

@chrisn
Copy link

chrisn commented May 1, 2023

👋 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants