Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing modal with ESC conflict #7144

Open
Unlimited23 opened this issue Apr 6, 2023 · 0 comments
Open

Closing modal with ESC conflict #7144

Unlimited23 opened this issue Apr 6, 2023 · 0 comments

Comments

@Unlimited23
Copy link

I have a modal on which I've set both properties: no-close-on-esc, no-close-on-backdrop to true. Backdrop works fine - clicking outside doesn't close the modal but it conflicts with the functionality of ESC button. What I mean is:

  1. If I click outside of modal (backdrop is probably set to true) and then press ESC the modal doesn't close but the expected behaviour would be to close the modal.
  2. However, if I click back somewhere inside the modal (backdrop is probably set to false) click ESC works as expected.

Anyhow, clicking on ESC when no-close-on-esc is set to true should always close the modal and it shouldn't be dependent on backdrop parameter, IMO. (ESC > backdrop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant