Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghidra addHighlightBrace has been renamed to addBraceHighlight in master #81

Open
alexmaloteaux opened this issue Dec 7, 2021 · 2 comments
Assignees

Comments

@alexmaloteaux
Copy link

not really an issue atm but more a warning, addHighlightBrace in ghidra master / 10.2 has been rename to addBracehighlight here :
https://github.com/NationalSecurityAgency/ghidra/blob/bed44bd55dc88c7c6fab5f158cdb4b9daa087519/Ghidra/Features/Decompiler/src/main/java/ghidra/app/decompiler/component/ClangHighlightController.java#L610

compilation of the plugin against master fails here :

addHighlightBrace((ClangSyntaxToken) token, defaultParenColor);

@bootleg bootleg self-assigned this Dec 7, 2021
@bootleg
Copy link
Owner

bootleg commented Dec 7, 2021

Hello Alexandre,

Big thank you for the heads-up here.

The highlighting code in the Ghidra plugin is really shaky right now.

I need to dig more into it but a stable highlighter service would be great, it was missing so far with many classes not exposed.
NationalSecurityAgency/ghidra@02ef610

I'll keep the issue open until the 10.2 is released and I update ret-sync code accordingly.

Thanks.

@bootleg bootleg pinned this issue Dec 8, 2021
@fenugrec
Copy link

fenugrec commented Dec 10, 2022

Hi,
this is preventing a build of ret-sync with gradle-7.6, jdk19, for ghidra 10.2.2 .

Ideas for a workaround ?
[edit] - there is, #96

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants