Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zip is not a function when using a local #85

Open
devbyray opened this issue Mar 13, 2019 · 2 comments · May be fixed by #98
Open

Zip is not a function when using a local #85

devbyray opened this issue Mar 13, 2019 · 2 comments · May be fixed by #98

Comments

@devbyray
Copy link

When I set the local to 'nl_NL' the zip is not a function but a property. I think this should be more consistent.
@josher19
Copy link

I think this was introduced by this commit / Pull Request:
https://github.com/boo1ean/casual/pull/26/files

It should be a property for every locale and should not be a function for any locale,

Instead of having zip(digits) it should have zip, zip5, and zip9 as properties rather than functions for a more consistent interface.

@josher19 josher19 linked a pull request Aug 21, 2020 that will close this issue
Open
@josher19
Copy link

Used zip_short and zip_long instead of zip5 and zip9 (which is specific to the USA).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix zip josher19/casual
2 participants
@josher19 @devbyray