Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ClangCL #180

Open
HITOA opened this issue Oct 24, 2022 · 0 comments
Open

Support for ClangCL #180

HITOA opened this issue Oct 24, 2022 · 0 comments

Comments

@HITOA
Copy link

HITOA commented Oct 24, 2022

It can compile with clang-cl but do not because of some macro in optick.h :

if defined(__clang__) || defined(__GNUC__)
#	define OPTICK_GCC (1)
#	if defined(__APPLE_CC__)
#		define OPTICK_OSX (1)
#	elif defined(__linux__)
#		define OPTICK_LINUX (1)
#	elif defined(__FreeBSD__)
#		define OPTICK_FREEBSD (1)
#	endif
#elif defined(_MSC_VER)
#	define OPTICK_MSVC (1)
#	if defined(_DURANGO)
#		define OPTICK_PC (0)
#	else
#		define OPTICK_PC (1)
#endif
#else
#error Compiler not supported
#endif

When clang-cl is used, both __clang__ and _MSC_VER are defined, it's a really small fix, but i think it's worth doing it :D!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant