-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what would it take to utilize prompt-toolkit (or replicate its features)? #668
Comments
#392 might benefit from this. |
I'd gladly accept an answer (or guesstimate) in the form of a price tag :) |
Yeah, that looks great :) I'm not sure what it'd take, but it seems possible to do. To be perfectly honest, I don't have the bandwidth to take it on right now, but if you're interested in taking a shot at it, I'm happy to help with a game plan, review code, answer questions and give suggestions! |
Sweet, I'm glad you like the idea, and it'd be super helpful to have some guidance in the process! As far as the overall biggest-picture approach... would you consider completely replacing GNU Readline with python-prompt-toolkit? |
Not as a hard dependency, no. But we currently support three different readline implementations for various reasons and adding a fourth for improved UX seems doable. There's also a Jupyter notebook integration that might be useful or informative. |
Prompt Toolkit is an awesome library that enables really awesome things like a MySQL client with autocompletion, vi-mode, and more and a Python REPL with all those ++ awesome features.
I really want suggested autocompletion, vi-mode, history substring search (among other awesome features) in my php repl.
I have no idea what would be involved in utilizing Prompt Toolkit in PSYSH.
But I think it would be awesome.
The text was updated successfully, but these errors were encountered: