-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable to customize ExecutionLoop Listeners #565
Comments
I understand what you want, but can you share a bit more about why? 🙂 |
I was trying to log every |
Right, but why? I still don’t understand your use case. I’m not opposed to opening up more extension points, but there is a maintenance and support cost associated, and this one hasn’t happened because I haven’t seen a good reason for it yet.
🙂 |
Currently it is no easy way to customize the execution loop listeners.
I managed to do that by extending
Psy\Shell
and overridinggetDefaultLoopListeners()
method:but that doesn't seem like a clean solution. I think we should enable users to customize them via constructor or
addLoopListener()
/setLoopListeners()
methods followingaddMatchers()
andaddTabCompletionMatchers()
methods convention so the code would become:@bobthecow WDYT?
The text was updated successfully, but these errors were encountered: