Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit Readiness #4

Closed
5 tasks done
gregdhill opened this issue Dec 6, 2023 · 0 comments · Fixed by #9
Closed
5 tasks done

Audit Readiness #4

gregdhill opened this issue Dec 6, 2023 · 0 comments · Fixed by #9
Labels
enhancement New feature or request help wanted Extra attention is needed prio:high Important due to deadlines and/or clear needs/benefits.

Comments

@gregdhill
Copy link

gregdhill commented Dec 6, 2023 •
edited

Summary of previous changes (snapdao#140):

To prepare the snap for a re-audit we should do the following:

  • use tapBip32Derivation instead of forcing path
  • remove old unused methods (e.g. signPSBT) (keep for backwards compatibility)
  • add derivation paths for taproot (BIP86)
  • cleanup / add more tests
  • review LN extensions (keep for backwards compatibility)
@nud3l nud3l added enhancement New feature or request help wanted Extra attention is needed prio:high Important due to deadlines and/or clear needs/benefits. labels Dec 6, 2023
@gregdhill gregdhill mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed prio:high Important due to deadlines and/or clear needs/benefits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[master] enable bip86 signing, cleanup and add tests bob-collective/bob-snap
2 participants
@gregdhill @nud3l