Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement console.groupCollapsed() method #3805

Closed
HalidOdat opened this issue Apr 14, 2024 · 4 comments · Fixed by #3867
Closed

Implement console.groupCollapsed() method #3805

HalidOdat opened this issue Apr 14, 2024 · 4 comments · Fixed by #3867
Assignees
Labels
E-Easy Easy enhancement New feature or request good first issue Good for newcomers

Comments

@HalidOdat
Copy link
Member

HalidOdat commented Apr 14, 2024

Specification: https://console.spec.whatwg.org/#groupcollapsed
MDN Documentation: https://developer.mozilla.org/en-US/docs/Web/API/console/groupcollapsed_static

@HalidOdat HalidOdat added enhancement New feature or request good first issue Good for newcomers E-Easy Easy labels Apr 14, 2024
@leoflalv
Copy link
Contributor

leoflalv commented May 25, 2024

Hi, could I work on this one?

@HalidOdat
Copy link
Member Author

Sure go ahead! :)

@leoflalv
Copy link
Contributor

leoflalv commented May 27, 2024

Hi, I've been doing some research on this topic. When you use console.group and console.groupCollapsed and run it with Node or Deno, you get exactly the same output for both commands. I also looked at the Deno's code, and they have groupCollapsed as an alias for group, as we have now. Instead of having groups just as String, I could turn it into a Group structure containing name: String and collapsed: bool, but I'm not sure this is going to give any relevant information to be honest. I think this issue should be closed, and just keep it the way it is now. Let me know what do you think about it.

Or another option could be implement the groupCollapsed just calling the group function inside, if is this what you want here is the pr for that #3867

@HalidOdat
Copy link
Member Author

I think it's good like this! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Easy Easy enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants