Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin 1.9.x support #104

Closed
rocketraman opened this issue Mar 17, 2024 · 7 comments
Closed

Kotlin 1.9.x support #104

rocketraman opened this issue Mar 17, 2024 · 7 comments

Comments

@rocketraman
Copy link

rocketraman commented Mar 17, 2024

Kotlin-power-assert seems to work with 1.9.x, and even the sample uses 1.9.x, but the README does not list it as supported. Can official support be added for it?

I do note this statement, but given that every previous version of Kotlin is listed, its easy to miss, or to assume the plugin has not been updated:

If a version of Kotlin or this plugin is not listed it can be assumed to maintain compatibility with the next oldest version listed.

@bnorm
Copy link
Owner

bnorm commented Mar 18, 2024

Yes, Kotlin 1.9.x is supported by 0.13.0. (Though I think there is a small incompatibility if an error needs to be reported, so I might need to release a new version)

The compatibility guide is not the easiest thing to make clear, so if you have any ideas on how to improve the README, let me know! Maybe I should make the Kotlin versions a range?

@rocketraman
Copy link
Author

Maybe I should make the Kotlin versions a range?

That seems reasonable.

@TWiStErRob
Copy link
Contributor

I've always found these helpful, although I also found them too implicit. So ++ on version ranges.

I'm also having "fun" trying to maintain a 3D compatibility matrix and found ranges very useful: https://github.com/TWiStErRob/net.twisterrob.gradle

@AlexTrotsenko
Copy link

AlexTrotsenko commented May 29, 2024

@bnorm similar question about Kotlin v2.0 - is current version of the power-assert plugin is expected to work with it well?

Also what about ID of the plugin ? I see, that kotlin documentation has different id there:
https://kotlinlang.org/docs/power-assert.html#apply-the-plugin

@bnorm
Copy link
Owner

bnorm commented May 30, 2024

Support for this plugin, starting with Kotlin 2.0.0, has moved into the Kotlin repository! Part of that move was to make it compatible with Kotlin 2.0 and update the artifact coordinates to align with other official compiler plugins. Everyone should migrate to the official compiler plugin (the documentation you linked) when upgrading to Kotlin 2.0.

This repository/plugin will not be updated to support Kotlin 2.0. I will be releasing a new version which fails Gradle builds and indicates as much in the failure message. I'm hoping to release this version soon and will also provide some documentation in the release notes/README about migrating.

@AlexTrotsenko
Copy link

@bnorm thank you very much for your quick and detailed reply and all your efforts in making this excellent powerful assert project!

@rocketraman
Copy link
Author

Support for this plugin, starting with Kotlin 2.0.0, has moved into the Kotlin repository!

Very cool! Congrats.

@bnorm bnorm closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants