Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The datetime directives used to format elapsed time are incorrect #10

Open
jakeb1996 opened this issue Oct 17, 2022 · 0 comments · May be fixed by #16
Open

The datetime directives used to format elapsed time are incorrect #10

jakeb1996 opened this issue Oct 17, 2022 · 0 comments · May be fixed by #16

Comments

@jakeb1996
Copy link
Member

When the elapsed time for a batch and the total elapsed time is reported, the expression %d %H:%M:%S is used. Even when the pipeline takes less than one day to run, the elapsed time will be reported with %d being one (i.e., taking at least 24 hours), as %d reports day of month (there is no 0'th day of a month). See here.

The code used to report elapsed time needs to be changed so that days/hours/minutes/seconds are reported accurately.

Crackling/src/crackling/Crackling.py

Line 886 in b00de36

time.strftime('%d %H:%M:%S', time.gmtime((time.time() - startTime))),

Crackling/src/crackling/Crackling.py

Line 879 in b00de36

time.strftime('%d %H:%M:%S', time.gmtime((time.time() - batchStartTime))),

@jakeb1996 jakeb1996 linked a pull request Jan 11, 2024 that will close this issue
Solution to fix github-issue-10 #16
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Solution to fix github-issue-10 bmds-lab/Crackling
1 participant
@jakeb1996