Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃惔] Conversations require two taps #4162

Open
ljstella opened this issue May 22, 2024 · 1 comment
Open

[馃惔] Conversations require two taps #4162

ljstella opened this issue May 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ljstella
Copy link

Describe the bug
Apologies if this is actually the intended behavior, but it seemed a bit unintuitive so I figured I'd report it anyway:

On the desktop site with a touch interface, conversations need to be tapped twice to open. The first tap appears to select them + shows the Settings dots, the second tap opens them. This is different than the behavior with a mouse connected, where the Settings appear on hover and the first click opens the conversation.

To Reproduce

Steps to reproduce the behavior:

  1. Login to the app & proceed to the Chat tab.
  2. Tap on a conversation.
  3. Observe the conversation being "selected" but not opened.
  4. Tap again. Observe the conversation being opened.

Expected behavior

Having also tested this exact set of actions on a desktop browser with a mouse and the mobile web version on an iPhone browser, I think the answer is "it depends". The "hover effect" to hide the settings on Desktop is nice, when you have a mouse. The always-show-the-settings-ellipsis behavior on the mobile web version is also nice. If there's a mechanism by which you can easily set Tablet-specific behaviors (desktop web app but touch interface), the mobile web behavior of always showing the dots makes more sense.

Screenshots

Video:
https://github.com/bluesky-social/social-app/assets/1413514/361ff627-6d10-4d35-a13b-8761ef6c8934

Details

  • Platform: iPadOS Safari
  • Platform version: iPadOS 17.5
  • App version: Build version: 1.83.0; Bundle info: dev (prod); Bundle date: 24052122; Platform: web

Additional context

@ljstella ljstella added the bug Something isn't working label May 22, 2024
@haileyok
Copy link
Member

Probably should do the same behavior we do on native: press and hold or double tap to open the menu. I'll hit that here shortly 馃憤 thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants