Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexicon specs are missing, links 404 #294

Open
str4d opened this issue Feb 17, 2024 · 4 comments
Open

Lexicon specs are missing, links 404 #294

str4d opened this issue Feb 17, 2024 · 4 comments

Comments

@str4d
Copy link

str4d commented Feb 17, 2024

Steps to reproduce

  1. Navigate to the documentation for a specific lexicon (e.g. https://atproto.com/guides/applications#appbskyfeedpost)
  2. Click on its name (which in the above case navigates to https://atproto.com/lexicons/app-bsky)

Expected

I should see the app.bsky lexicon specification (ideally for app.bsky.feed.post in the above example).

Actual

A very pretty 404 error page.

@str4d
Copy link
Author

str4d commented Feb 17, 2024

The bad links are here:

### <a href="/lexicons/app-bsky">app.bsky.feed.post</a>

The lexicon specifications they linked to were removed in #283.

@str4d
Copy link
Author

str4d commented Feb 17, 2024

There are existing redirects for legacy lexicon subpages to the (now-removed) combined lexicon pages, that would also need to be updated:

{
source: '/lexicons/com-atproto-admin',
destination: '/lexicons/com-atproto',
permanent: false,
},
{
source: '/lexicons/com-atproto-identity',
destination: '/lexicons/com-atproto',
permanent: false,
},
{
source: '/lexicons/com-atproto-label',
destination: '/lexicons/com-atproto',
permanent: false,
},
{
source: '/lexicons/com-atproto-moderation',
destination: '/lexicons/com-atproto',
permanent: false,
},
{
source: '/lexicons/com-atproto-repo',
destination: '/lexicons/com-atproto',
permanent: false,
},
{
source: '/lexicons/com-atproto-server',
destination: '/lexicons/com-atproto',
permanent: false,
},
{
source: '/lexicons/com-atproto-sync',
destination: '/lexicons/com-atproto',
permanent: false,
},
{
source: '/lexicons/com-atproto-sync',
destination: '/lexicons/com-atproto',
permanent: false,
},
{
source: '/lexicons/app-bsky-actor',
destination: '/lexicons/app-bsky',
permanent: false,
},
{
source: '/lexicons/app-bsky-embed',
destination: '/lexicons/app-bsky',
permanent: false,
},
{
source: '/lexicons/app-bsky-feed',
destination: '/lexicons/app-bsky',
permanent: false,
},
{
source: '/lexicons/app-bsky-graph',
destination: '/lexicons/app-bsky',
permanent: false,
},
{
source: '/lexicons/app-bsky-notification',
destination: '/lexicons/app-bsky',
permanent: false,
},
{
source: '/lexicons/app-bsky-richtext',
destination: '/lexicons/app-bsky',
permanent: false,
},

@lucalves
Copy link

Hello, I opened PR #295 removing the links and fixing the redirects that caused the 404 error. Let's wait for the review.

@bnewbold
Copy link
Contributor

I think with the above PR these are resolved. We should still update/replace these pages to not have any lexicon links, or to link to https://docs.bsky.app, but I think the urgent bug is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants