Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking to download video caused Cockpit to offer a zip with the chunks #948

Closed
rafaellehmkuhl opened this issue May 10, 2024 · 5 comments · Fixed by #966
Closed

Clicking to download video caused Cockpit to offer a zip with the chunks #948

rafaellehmkuhl opened this issue May 10, 2024 · 5 comments · Fixed by #966
Assignees
Labels
investigate P0 - Critical Priority Highest priority over all priorities ui UI related issues ux Has to do with the user experience video

Comments

@rafaellehmkuhl
Copy link
Member

That was a problem faced by Brian Austin (BR):

When I clicked the large download icon in the bottom right, it downloaded a large zip file of 326 files in it and none were the actual video file. Then I was able to click on the menu on the actual video and download from there and that one worked and gave me the video file

@rafaellehmkuhl rafaellehmkuhl added bug Something isn't working ui UI related issues P0 - Critical Priority Highest priority over all priorities ux Has to do with the user experience video labels May 10, 2024
@rafaellehmkuhl rafaellehmkuhl added this to the From Beta to Stable milestone May 10, 2024
@ArturoManzoli
Copy link
Contributor

I haven't experienced that as an issue or bug yet, but I do recognize this behavior as intentional.
What might have happened to Brian is one of the following situations:

1- If you select an unprocessed video, the download will be a ZIP containing the video's chunks. Downloading the chunks could be useful if the cockpit cannot process the video.
2- If you select multiple unprocessed videos, the download will be a ZIP containing all selected video chunks in the root directory, with files named by hash.
3- If you select multiple videos and among them there are both processed and unprocessed videos, the download will consist of two ZIP files: one for the processed .webm and .ass files, and another for the unprocessed ones.

@rafaellehmkuhl rafaellehmkuhl removed the bug Something isn't working label May 14, 2024
@rafaellehmkuhl
Copy link
Member Author

I haven't experienced that as an issue or bug yet, but I do recognize this behavior as intentional. What might have happened to Brian is one of the following situations:

1- If you select an unprocessed video, the download will be a ZIP containing the video's chunks. Downloading the chunks could be useful if the cockpit cannot process the video. 2- If you select multiple unprocessed videos, the download will be a ZIP containing all selected video chunks in the root directory, with files named by hash. 3- If you select multiple videos and among them there are both processed and unprocessed videos, the download will consist of two ZIP files: one for the processed .webm and .ass files, and another for the unprocessed ones.

Got it.

So it's an UX problem, not a bug in the software.

Maybe a solution is to add a confirmation dialog saying that the user is downloading chunks instead of the video, on those situations?

@ArturoManzoli
Copy link
Contributor

Maybe we should also differentiate more clearly the processed and unprocessed videos on the Video Library.

On top of that, we can change the ZIP filenames for something more descriptive.
Now processed videos are named Cockpit-Video-Recovery - 2024-05-14T094324.981.zip and unprocessed are named Cockpit-Temp-Video-Chunks-88f8f692.zip

@rafaellehmkuhl
Copy link
Member Author

More info on that: Brian said he had clicked the process button already. Maybe the download button was available while the video was being processed?

@ArturoManzoli
Copy link
Contributor

Yes, this might have happened. The button should disabled while the videos is processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate P0 - Critical Priority Highest priority over all priorities ui UI related issues ux Has to do with the user experience video
Projects
Status: Done
2 participants