-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Spec be a list of flags #918
Labels
feature
New feature or lib ability
Comments
i would like to take this up , is there any additional context to this issue ? |
Can I work on this if no one started? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently const generic is defined as an Enum that is used as generic on the functions. This becomes problematic if we want to add some new features and enable just one of them.
Presently on optimism use case where they want to have the hardfork in the middle of existing ones it becomes impossible to define outside of evm and they need to feature gate the new Spec enum with their own.
The main problem is that the Present spec id is considered as a number and assumption is that everything less than this is activated, the idea is to have flag per hardfork and allow granular control of what is enabled. This would additionally allow defining custom hardfork that can be activated on any time.
An additional benefit is enabling future EIPs which would allow testing on isolation, when that EIP get merged into hardfork all flags for it would be merged into one.
The text was updated successfully, but these errors were encountered: