-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(revm): allow for Evm
to be Send + Sync
#1152
Comments
This is probably not going to happen with whole |
The database will still be a problem to be shared. |
Problem
Right now, we cannot share
Evm<_>
across thread boundaries as there are certain handlers that are not set to beSend + Sync
. E.g.:revm/crates/revm/src/handler/handle_types/validation.rs
Lines 9 to 19 in 13ce013
This restricts being able to do
Arc<RwLock<Evm<_>>>
and having shared access to anEvm<_>
instance where one could be able to parallelize over read-only txs.Solution
dyn Fn
s withSend + Sync
, however I don't think this is what revm wants. Perhaps this could be an option under a feature flag?Related Issues
It was brought up that #916 was related, and I began trying to work on this. I want to open up this issue here to keep it in mind and discuss.
The text was updated successfully, but these errors were encountered: