New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why make_forecasting_frame does not have min_timeshift argument? #992

Open

arashag opened this issue Dec 19, 2022 · 1 comment

Labels

arashag commented Dec 19, 2022 •

edited

The problem:

Hi. I noticed that when using make_forecasting_frame, it does not have min_timeshift argument so the first few rows have less predictor rows.

Environment:

Python version: 3.8.16
Operating System: Ubuntu
tsfresh version: 0.19.0
Install method (conda, pip, source): pip-Colab

arashag added the bug label

Collaborator

nils-braun commented Feb 21, 2023

That is corect @arashag ! Would you like to file a PR to fix this? It should be enough to just forward it to the call to roll_time_series

nils-braun added enhancement and removed bug labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment