Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-arch docker images #94

Open
surskitt opened this issue Aug 23, 2020 · 6 comments
Open

Multi-arch docker images #94

surskitt opened this issue Aug 23, 2020 · 6 comments

Comments

@surskitt
Copy link

surskitt commented Aug 23, 2020

Is your feature request related to a problem? Please describe.

I am unable to use the standard docker hub image on a raspberr pi cluster.

Describe the solution you'd like

I'm not sure if travis supports it, but buildx can be used to build multi-arch images than can then be pushed to docker hub.

Describe alternatives you've considered

I have forked the repo and added my own github action to buidl the multi arch image. It would be nice to have the official image support this though.

@seeker89
Copy link
Contributor

This is a good call. We are using Travis for building the docker images, so adding the support for this should be as straighforward as it was in this PR https://github.com/bloomberg/powerfulseal/pull/289/files

@shanedabes would you like to contribute a PR with that? Thanks for the issue!

@surskitt
Copy link
Author

It looks like that PR is created separate images for amd64 and arch, there's a little bit more involved in creating actual multi arch images. I'll look up what's involved in doing that with travis and submit a PR then.

@mtougeron
Copy link
Contributor

I'd like to pick this up and make a PR for multi-arch build but I had two questions.

  • I need this for arm64 & amd64. Are there any other architectures or OS that you'd like me to add at the same time?
  • I was basically thinking of following Multi-arch build, what about Travis? from Docker's blog to do this, is that acceptable to you?

@seeker89
Copy link
Contributor

I think that arm64 and amd64 is all that we need right now.

That said, I've been meaning to move off of Travis onto Github actions. I'll hopefully get to that in the next week or so, so perhaps hold off until then.

Thanks for volunteering for that @mtougeron - much appreciated! 👍

@mtougeron
Copy link
Contributor

Awesome, thanks. Doing it with GH actions is even easier! :)

@mtougeron
Copy link
Contributor

@seeker89 FWIW, I created a draft PR with the multi-arch changes + Github action for publishing. #109 I figured it might save you some time with the move from Travis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants