Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Bundle yarn or specific version in package.json #15

Open
SettingDust opened this issue Aug 6, 2023 · 8 comments
Open

[Request] Bundle yarn or specific version in package.json #15

SettingDust opened this issue Aug 6, 2023 · 8 comments

Comments

@SettingDust
Copy link

Seems my yarn 3 break the lock file when import the project

@GNRSN
Copy link

GNRSN commented Aug 8, 2023

I think the current lockfile was generated with Yarn classic (v1), not Berry (v2/v3).

@SettingDust
Copy link
Author

I think the current lockfile was generated with Yarn classic (v1), not Berry (v2/v3).

ya

@GNRSN
Copy link

GNRSN commented Aug 8, 2023

It's not really possible to "bundle" a package-manager with a repo. Corepack will adress this but it's still in an experimental stage the requires opt-in so it's not really feasible for real use as you can't expect developers to have it enabled.

The established "solution" OSS is afaik to document the package-manager used under the contributing section of the readme.md.

@SettingDust
Copy link
Author

It's not really possible to "bundle" a package-manager with a repo. Corepack will adress this but it's still in an experimental stage the requires opt-in so it's not really feasible for real use as you can't expect developers to have it enabled.

The established "solution" OSS is afaik to document the package-manager used under the contributing section of the readme.md.

False.
https://yarnpkg.com/features/zero-installs

@mProjectsCode
Copy link

Why do something like this? Every package manager should work, no?

And if another package manager changes the package-lock.json, just don't include the changes in the commit.

@SettingDust
Copy link
Author

SettingDust commented Aug 8, 2023

Why do something like this? Every package manager should work, no?

And if another package manager changes the package-lock.json, just don't include the changes in the commit.

In some situation package url will different with the same package manifest.

@GNRSN
Copy link

GNRSN commented Aug 8, 2023

False. https://yarnpkg.com/features/zero-installs

I stand corrected, however that's a "feature" of Yarn Berry that also requires the PnP feature of Yarn Berry to be utilised.

@SettingDust
Copy link
Author

SettingDust commented Aug 8, 2023

False. yarnpkg.com/features/zero-installs

I stand corrected, however that's a "feature" of Yarn Berry that also requires the PnP feature of Yarn Berry to be utilised.

Noop. It's a feature of yarn. And needn't pnp. PnP is for actually zero install. But specific the yarn version or bundle the yarn is what I said

Which just need yarn set version <version>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants