Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : scrolling message #190

Open
R0lleston opened this issue Jul 23, 2021 · 28 comments
Open

Feature request : scrolling message #190

R0lleston opened this issue Jul 23, 2021 · 28 comments

Comments

@R0lleston
Copy link

Anyone up for creating a continuous scrolling message plugin?

  • message could be saved in config file
  • option of single colour or rainbow

Example could be "Happy Birthday Monty"

@bk1285
Copy link
Owner

bk1285 commented Jul 24, 2021

Nice idea, @R0lleston

If anyone want's to go for it, please

  • base your work on current develop branch (python3)
  • consider a plugin (combined with message within the config file) or even a API-endpoint, allowing to send text via the webinterface to the clock.

@R0lleston
Copy link
Author

@bk1285 look forward to seeing what your team of coding magicians can come up with....... my kids would love a feature like this for welcoming guests to say one of their birthday parties, especially if its colourful

@FrankX0
Copy link
Contributor

FrankX0 commented Jul 26, 2021

Like the idea!
I can see two implementations:

  1. Special occasions.
    Using a plugin, with API-endpoint. Setting the text, repeat time, colour, etc. through the webinterface
  2. Repeating occasions.
    Like for birthdays, new-years, etc.. These should go into the config file with text, date, repeat time, etc.

@R0lleston
Copy link
Author

@FrankX0 sounds perfect, we just need to talk nicely to a coder to bring this to reality.
how about also the option (if possible) of the background pixel lit slightly, with the words themselves fully lit (to the give the effect of one of those scrolling message devices).

@bk1285
Copy link
Owner

bk1285 commented Jul 27, 2021

Sound's promising, @FrankX0. Amendment to your comment:
Option 2. should probably use the new transitions, where the text (including colour-settings, etc.) is animated without explicitly running a plugin. Transitions would need some further refactoring first.
Option 2 could furthermore be realized:

  • 2.a: Based on config file
  • 2.b: Accessing a calendar via caldav (.... if anyone volunteers... 🙈 ) At least, in my calendar, all birthdays are noted and additional (reoccurring) events could be displayed as some sort of reminder... 😉

@R0lleston
Copy link
Author

@FrankX0 @bk1285 has anyone been allocated to this or taken it on themselves to have a go

@FrankX0
Copy link
Contributor

FrankX0 commented Aug 16, 2021

I will start having a look (especially the web interface) when I get back from holiday.
Cannot make any promises though.

@bk1285
Copy link
Owner

bk1285 commented Aug 16, 2021

Sounds great, @FrankX0!

as mentioned before, please use the latest develop branch of this repo to start implementing this. (...since this project keeps receiving pull requests from branches, which were forked loong time ago... )

Best,
Bernd

@FrankX0
Copy link
Contributor

FrankX0 commented Aug 23, 2021

Initial prototype for the user interface:

  • Text to scroll
  • Start date and time
  • Repeating period
  • Enable/disable switch

image

Feedback is appreciated.

@R0lleston
Copy link
Author

@FrankX0 Big thumbs up from here, looks great. Is it envisaged that the message will be able to scroll continiously and with time delays of seconds as well as minutes? If so, then brilliant !

@FrankX0
Copy link
Contributor

FrankX0 commented Aug 24, 2021

@R0lleston If the repeat time is set to 0 it will scroll continuously (maybe I should call it delay?).
I was thinking specifying the delay in minutes was small enough.
To not over-complicate things, I could change the delay to be specified in seconds. Would that be OK?

@R0lleston
Copy link
Author

@FrankX0 that would be perfect (delay in seconds) fantastic stuff

@bk1285
Copy link
Owner

bk1285 commented Aug 25, 2021

Looks great, @FrankX0

How about hiding this in a collapsed layout by default?

Best,
Bernd

@FrankX0
Copy link
Contributor

FrankX0 commented Aug 25, 2021

Like this?
imageimage

@R0lleston
Copy link
Author

@bk1285 @FrankX0 I realise life is busy but was wondering how progress is going :) hope the weekend is going well

@FrankX0
Copy link
Contributor

FrankX0 commented Oct 11, 2021

I continued working on it. The web interface is ready, now working on the rest of the implementation.
I should have something to share in the coming weeks.

@R0lleston
Copy link
Author

Fantastic news @FrankX0 , appreciate all that you are doing :)

@FrankX0
Copy link
Contributor

FrankX0 commented Oct 19, 2021

I have made an initial implementation, with the user interface but yet without the repeating message.
You can find it here:
https://github.com/FrankX0/rpi_wordclock/tree/develop
It is based on the current (Pyhton3) development branch.
The message will show when the "enable" switch is turned on (although I could not test it on an actual clock).

I am not yet sure how to do the time triggering and repeating of the text though.
I was thinking of using a scheduler, but that's not working yet.
@bk1285 any suggestions? I can certainly use some help in this area.

@FrankX0
Copy link
Contributor

FrankX0 commented Oct 31, 2021

Hi @R0lleston
I just created a pull request (#210) for the development branch.
Please test and let me know what you think.

@R0lleston
Copy link
Author

Hi @R0lleston I just created a pull request (#210) for the development branch. Please test and let me know what you think.

@FrankX0 i saw this just pop up in my email. Very exciting, I'll try and a squeeze some time in over the weekend for a test. Thank you :)

@R0lleston
Copy link
Author

@FrankX0 getting the following error when trying to run

clock

@FrankX0
Copy link
Contributor

FrankX0 commented Nov 1, 2021

Sorry, last minute change.
Should be fixed now.

@R0lleston
Copy link
Author

@FrankX0 have reinstalled from your 'develop' directory, no errors now, but the config file (or other bits) need modifying to allow for the new plugin...... ie it doesnt show in the list to enable or disable, thus doesnt come up as an option on your web interface

@FrankX0
Copy link
Contributor

FrankX0 commented Nov 2, 2021

This is not a new plugin. So the config file does not need modifying.
It could be that your browser is still caching the old web interface.
In (Windows) Chrome you can do an "Empty Cache and Hard Reload".
On iOS I always have problems when changing the web interface. This will "correct itself eventually".

@R0lleston
Copy link
Author

@FrankX0 you were bang on the money, it was an iOS issue, I retried lastnight on my windows pc and it worked nicely. I do like the clock implementation you did. I had a play around and it worked nicely, the only thing I noticed is that if you have message running and you change it to another, the display glitches with random lit up LEDs briefly and then recovers and works correctly. Without knowing a hell of a lot about how the clock works, it could be just how the clock software operates and your new code has highlighted it. But really good job.... hopefully a few others will give this a good test.

@R0lleston
Copy link
Author

@bk1285 @FrankX0 I'm not sure how must testing you two have done on an actual clock, but there is an issue with how the scrolling word feature when existing plugins are in use. This morning while demonstrating it to my kids - I had the matrix - with time plugin going, when the scrolling time starts, the matrix keeps going, while the text scroll begins to start up and these is random leds coming on. We might need to clear the wordclock display of the current plugin, before starting the scrolling text. Its easily reproducable if you want to see what im referring to :)

@FrankX0
Copy link
Contributor

FrankX0 commented Nov 5, 2021

For now this feature is implemented to only work the standard clock-face, not with any other plugins. Sorry.
When I have time I can see how to support other plugins.
But for now, please only use it with the standard face.

@FrankX0
Copy link
Contributor

FrankX0 commented Nov 14, 2021

@R0lleston I just made a fix for the scrolling text in combination with the matrix-with-time plugin.
Can you try again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants