Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fc::fstream to be more like std::fstream #1116

Open
1 of 17 tasks
jmjatlanta opened this issue Jul 4, 2018 · 1 comment · May be fixed by #2047
Open
1 of 17 tasks

Refactor fc::fstream to be more like std::fstream #1116

jmjatlanta opened this issue Jul 4, 2018 · 1 comment · May be fixed by #2047
Labels
1a Epic High level concept to be addressed. Description should contain a list referencing child User Stories 2a Discussion Needed Prompt for team to discuss at next stand up. 3c Enhancement Classification indicating a change to the functionality of the existing imlementation
Projects
Feature Release (7.1.0)
Milestone
7.1.0 - Feature R...

Comments

@jmjatlanta
Copy link
Contributor

User Story
As a developer I want to use fc::fstream so that it works like most other fstream library classes/functions.

Impacts

  • API (the application programming interface)
  • Build (the build process or something prior to compiled code)
  • CLI (the command line wallet)
  • Deployment (the deployment process after building such as Docker, Travis, etc.)
  • DEX (the Decentralized EXchange, market engine, etc.)
  • P2P (the peer-to-peer network for transaction/block propagation)
  • Performance (system or user efficiency, etc.)
  • Protocol (the blockchain logic, consensus, validation, etc.)
  • Security (the security of system or user data, etc.)
  • UX (the User Experience)
  • Other (please add below)

Additional Context (optional)
fc::fstream had a deficiency that files could not be opened in append mode. See issue #809. As part of the research for that issue, it was found that the mode parameter does not work as one would expect after working with fstream of the standard library or boost. See #809 (comment).

Making fc::fstream compatible with std::fstream will require careful examination of all uses, to make sure they work the same as today. We may even find uses where they are expecting it to work like std::fstream but it is not.

CORE TEAM TASK LIST

  • Evaluate / Prioritize Feature Request
  • Refine User Stories / Requirements
  • Define Test Cases
  • Design / Develop Solution
  • Perform QA/Testing
  • Update Documentation
@jmjatlanta jmjatlanta changed the title Refactor fc::fstream Refactor fc::fstream to be more like std::fstream Jul 4, 2018
@ryanRfox ryanRfox added 1a Epic High level concept to be addressed. Description should contain a list referencing child User Stories 2a Discussion Needed Prompt for team to discuss at next stand up. 3c Enhancement Classification indicating a change to the functionality of the existing imlementation labels Jul 11, 2018
@ryanRfox ryanRfox added this to New -Awaiting Core Team Evaluation in Project Backlog via automation Jul 11, 2018
@pmconrad pmconrad linked a pull request Nov 7, 2019 that will close this issue
Open
@pmconrad
Copy link
Contributor

pmconrad commented Nov 7, 2019

Actually I think we should replace fc::fstream with std::fstream instead of modifying the former to behave like the latter.

@pmconrad pmconrad removed this from New -Awaiting Core Team Evaluation in Project Backlog Nov 7, 2019
@pmconrad pmconrad added this to To do in Protocol Upgrade Release (5.0.0) via automation Nov 7, 2019
@pmconrad pmconrad mentioned this issue Nov 10, 2019
Open
@abitmore abitmore moved this from To do to In development in Protocol Upgrade Release (5.0.0) May 1, 2020
@abitmore abitmore added this to To do in Feature Release (5.1.0) via automation Sep 13, 2020
@abitmore abitmore removed this from In development in Protocol Upgrade Release (5.0.0) Sep 13, 2020
@abitmore abitmore moved this from To do to In development in Feature Release (5.1.0) Sep 13, 2020
@abitmore abitmore linked a pull request Sep 13, 2020 that will close this issue
Get rid of fc/io/fstream.hpp #2047
Open
@abitmore abitmore removed this from In development in Feature Release (5.1.0) Jan 6, 2021
@abitmore abitmore added this to To do in Feature Release (5.2.0) via automation Jan 6, 2021
@abitmore abitmore removed this from To do in Feature Release (5.2.0) Apr 13, 2021
@abitmore abitmore added this to To do in Feature Release (6.1.0) via automation Apr 13, 2021
@abitmore abitmore removed this from To do in Feature Release (6.1.0) Jul 31, 2022
@abitmore abitmore added this to To do in Feature Release (7.1.0) via automation Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1a Epic High level concept to be addressed. Description should contain a list referencing child User Stories 2a Discussion Needed Prompt for team to discuss at next stand up. 3c Enhancement Classification indicating a change to the functionality of the existing imlementation
Projects
Feature Release (7.1.0)
To do
Milestone
7.1.0 - Feature Release
Development

Successfully merging a pull request may close this issue.

Get rid of fc/io/fstream.hpp pmconrad/bitshares-core
4 participants
@jmjatlanta @pmconrad @abitmore @ryanRfox