-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting mismatched with code in getting-started branch #349
Comments
This seems somewhat expected to me. If you use the formatter for the project, you'll get the same results (once the line reaches 140+ characters, it'll not inline the array). I wouldn't want to inline all of those imports onto one line. Nor would I want to claim that the whole line has changed. We're only adding one extra import. We don't include this branch in the academy, but here's the branch that shows the imports diff as one line: bitovi/angular-ngrx-chat@ngrx-init-feature...ngrx-init-manual-changes I think that we could avoid some confusion by mentioning that we have a formatter installed as a dev-dependency and you can -instructions on how to format- to view the same results |
I've landed on trying to explain how to use prettier~ |
I've added a part explaining prettier: #354 Not sure if this makes things clear enough though. I'll get my eyes on this section for further feedback |
^This formatting
does not match
below code in the starting-point branch
The text was updated successfully, but these errors were encountered: