Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/haproxy] allow to set enableServiceLinks #25851

Closed
olivierboudet opened this issue May 14, 2024 · 1 comment · Fixed by #25852
Closed

[bitnami/haproxy] allow to set enableServiceLinks #25851

olivierboudet opened this issue May 14, 2024 · 1 comment · Fixed by #25852
Assignees
@carrodher
Labels
feature-request haproxy solved triage Triage is needed

Comments

@olivierboudet
Copy link
Contributor

Name and Version

bitnami/haproxy 1.1.2

What is the problem this feature will solve?

I need to set enableServiceLinks: false because I have too much environment variables, the chart does not allow to set it.

What is the feature you are proposing to solve the problem?

I propose to add a chart value enableServiceLinks, true by default.

What alternatives have you considered?

No response
@github-actions github-actions bot added the triage Triage is needed label May 14, 2024
olivierboudet added a commit to olivierboudet/charts-1 that referenced this issue May 14, 2024
@olivierboudet
[bitnami/haproxy] Add enableServiceLinks (bitnami#25851)
ee1ee21 
Signed-off-by: Olivier Boudet <[email protected]>
@olivierboudet olivierboudet mentioned this issue May 14, 2024
Merged
4 tasks
olivierboudet added a commit to olivierboudet/charts-1 that referenced this issue May 14, 2024
@olivierboudet
[bitnami/haproxy] Add enableServiceLinks (bitnami#25851)
681f3ae 
Signed-off-by: Olivier Boudet <[email protected]>
@carrodher
Copy link
Member

Thank you for opening this issue and submitting the associated Pull Request. Our team will review and provide feedback. Once the PR is merged, the issue will automatically close.

Your contribution is greatly appreciated!

migruiz4 pushed a commit that referenced this issue May 17, 2024
@olivierboudet
[bitnami/haproxy] Add enableServiceLinks (#25851) (#25852)
e239577 
Signed-off-by: Olivier Boudet <[email protected]>
fmulero pushed a commit to fmulero/charts that referenced this issue May 22, 2024
@olivierboudet @fmulero
[bitnami/haproxy] Add enableServiceLinks (bitnami#25851) (bitnami#25852)
9315e1d 
Signed-off-by: Olivier Boudet <[email protected]>
Signed-off-by: Fran Mulero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carrodher carrodher

Labels
feature-request haproxy solved triage Triage is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bitnami/haproxy] Add enableServiceLinks (#25851) olivierboudet/charts-1
2 participants
@olivierboudet @carrodher