Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose adding a delimeter to Column() #180

Open
rmasci opened this issue Aug 4, 2023 · 0 comments
Open

Propose adding a delimeter to Column() #180

rmasci opened this issue Aug 4, 2023 · 0 comments

Comments

@rmasci
Copy link

rmasci commented Aug 4, 2023

Right now Columns takes an int, and uses strings.Fields to split the line. I'd like to propose we add a delimiter, so that you could parse csv, semicolon, or pipe delimited files. The function would look like this:

func (p *Pipe) Column(col int, d ...string) *Pipe {
	var delim string
	if len(d) > 0 {
		delim = d[0]
	}
	return p.FilterScan(func(line string, w io.Writer) {
		var columns []string
		if delim == "" {
			columns = strings.Fields(line)
		} else {
			columns = strings.Split(line, delim)
		}
		if col > 0 && col <= len(columns) {
			fmt.Fprintln(w, columns[col-1])
		}
	})
}

d is a ...string means it takes 0 or more arguments, so if the user doesn't pass anything it still works maintaining compatibility with existing programs
Ex:

script.Exec(`echo "one two three"`).Columns(2).Stdout()

would still print 2. However

script.Exec(`echo "one,two,three"`).Columns(2, ",").Stdout() 

Would also print 2
Sort of a simple change, and it works for a case where I want to parse through comma separated lines. While I think it works, I might not be thinking of a use case where it would break existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant