Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSBT Taproot Key Path Finalizer Assumes Fixed 64-byte Signature Length #2004

Open
saravanan7mani opened this issue Nov 17, 2023 · 1 comment
Open

PSBT Taproot Key Path Finalizer Assumes Fixed 64-byte Signature Length #2004

saravanan7mani opened this issue Nov 17, 2023 · 1 comment
Assignees
@motorina0
Labels
bug

Comments

@saravanan7mani
Copy link

The PSBT Taproot keypath finalizer assumes a fixed signature length of 64 bytes, overlooking the variability (64 or 65 bytes) based on the sighash type (default or not). This could lead to errors, especially with non-default sighash types.
@junderw junderw added the bug label Nov 17, 2023
@kevinfaveri
Copy link

any news ont his @junderw?

@kevinfaveri kevinfaveri mentioned this issue Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@motorina0 motorina0

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@motorina0 @junderw @kevinfaveri @saravanan7mani