{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":238734190,"defaultBranch":"master","name":"rust-electrum-client","ownerLogin":"bitcoindevkit","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2020-02-06T16:33:53.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/62867074?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716909430.0","currentOid":""},"activityList":{"items":[{"before":"1899234f2ebc7ead95295c5ac004a641ab22d51c","after":"64c77ee1bc90c5e19ec0d401b97e420d495d7c6d","ref":"refs/heads/master","pushedAt":"2024-05-28T15:03:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#128: ci: add test with MSRV 1.63.0\n\n4b421084e912cb7395ea49c1bc7955b445270feb ci: add test with MSRV 1.63.0 (Steve Myers)\n\nPull request description:\n\n Since the main BDK crates are changing to MSRV 1.63.0 as is LDK the CI for this project should also have an MSRV and test against it in CI.\n\n Also rustc 1.63 is the version shipped with the current debian stable (bookworm): https://packages.debian.org/stable/rust/rustc\n\nACKs for top commit:\n oleonardolima:\n utACK 4b421084e912cb7395ea49c1bc7955b445270feb\n storopoli:\n ACK 4b42108\n ValuedMammal:\n ACK 4b421084e912cb7395ea49c1bc7955b445270feb looks good to me\n\nTree-SHA512: baff75887008a586af0ef0c4f50dd8c7c3de782f2dc6bc7d94c072c95205d4ef1a339860b3674dd781ad5558b98b071ed49b3a48507219b747e14c394dfe0a7b","shortMessageHtmlLink":"Merge #128: ci: add test with MSRV 1.63.0"}},{"before":"1bbae7d5a06909e5d7fb94937b94b0522b16bf01","after":"1899234f2ebc7ead95295c5ac004a641ab22d51c","ref":"refs/heads/master","pushedAt":"2024-05-27T17:54:16.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#133: chore(deps): upgrade `rust-bitcoin` to `0.32.0`\n\n6cf723504f9bc943b24ecb2c9d1e0829cdbe95d2 deps: bump crate version to `0.20.0` (Leonardo Lima)\n78cb0669665022bf7aa940de23d35b07ca84a1eb chore(deps)): upgrade `rust-bitcoin` to `0.32.0` (Leonardo Lima)\n\nPull request description:\n\n \n\n partially fixes [#1422](https://github.com/bitcoindevkit/bdk/issues/1422)\n\n ### Description\n\n It updates the rust-bitcoin to 0.32.0, the `bitcoin` crate dependency.\n\n _NOTE: The overall BDK update to `0.32.0` still requires and depends on some other crates, please refer to [#1422](https://github.com/bitcoindevkit/bdk/issues/1422)._\n\n \n\n ### Notes to the reviewers\n\n It's open for any comments.\n \n\n ### Changelog notice\n\n - Update the `bitcoin` crate dependency to `0.32.0`\n\n \n \n\n ### Checklists\n\n #### All Submissions:\n\n * [x] I've signed all my commits\n * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)\n * [x] I ran `cargo fmt` and `cargo clippy` before committing\n\nACKs for top commit:\n notmandatory:\n utACK 6cf723504f9bc943b24ecb2c9d1e0829cdbe95d2\n\nTree-SHA512: c1e170d8da7687b40916b7c2de48f08ca393a2af79522abc85933bae1da6f79d2aa05d59c73b99dcbd01cc7add4def1b8a14e7858550d4e7a007c07279b45854","shortMessageHtmlLink":"Merge #133: chore(deps): upgrade rust-bitcoin to 0.32.0"}},{"before":"898f230081106ba0c000c4914d8d241ac063374c","after":"1bbae7d5a06909e5d7fb94937b94b0522b16bf01","ref":"refs/heads/master","pushedAt":"2024-05-27T17:53:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#132: Upgrade rustls to 0.23\n\n28b1aaa0c304c52eb98d13ddc4bcc9e066c515ce upgrade rustls to 0.23 (Nick Farrow)\n\nPull request description:\n\n With rustls 0.23 there is no longer a dependency on ring, allowing easier compilation for various targets.\n\n Not super confident with my updates to `ServerCertVerifier` and `Der` of certificates (is this being tested?), needs review.\n\nACKs for top commit:\n notmandatory:\n utACK 28b1aaa0c304c52eb98d13ddc4bcc9e066c515ce\n\nTree-SHA512: 6561c4d20d446d86ca7a6c04ddb5a8acb136756606c82ca00e9b4a1f0eb2a3b00120d6db475f14474a89ebaa2ad600208d51c777cb5aeed0dcf62335a84fee5a","shortMessageHtmlLink":"Merge #132: Upgrade rustls to 0.23"}},{"before":"fd81717f8e97f909a1cfebfe86ffc25e3a5f8a55","after":"898f230081106ba0c000c4914d8d241ac063374c","ref":"refs/heads/master","pushedAt":"2023-12-19T14:38:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#126: Bump version to 0.19.0 and add CHANGELOG.md\n\nef9fd6bf507592ba9447e94059f1dc1ccdbbe398 Bump version to 0.19.0 and add CHANGELOG.md (Steve Myers)\n\nPull request description:\n\n Besides bumping the version I've also added a simple changelog that list the PRs in this (0.19.0) and the prior (0.18.0) release. The main reason for this release is the bump of the rust-bitcoin version to 0.31.0 which is needed to upgrade dependent projects like bdk to also use rust-bitcoin 0.31.0.\n\nACKs for top commit:\n evanlinjin:\n ACK ef9fd6bf507592ba9447e94059f1dc1ccdbbe398\n\nTree-SHA512: c18a0312915adfad40ef900ac4f1ee10454863f7a29882f1fa8f967f4c13df34b4e3929703614d0c3e6b8a189338f3a4d15b8d4598f68b87948454184fb13957","shortMessageHtmlLink":"Merge #126: Bump version to 0.19.0 and add CHANGELOG.md"}},{"before":"91228df8a50d7913a22a98c61eaba993acb5e6f6","after":"fd81717f8e97f909a1cfebfe86ffc25e3a5f8a55","ref":"refs/heads/master","pushedAt":"2023-12-08T22:11:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#125: enforce timeout on initial socks5 proxy connection\n\nd8554fb550c87bbbcb3c129b2679a22d5f6dc70b enforce timeout on initial socks5 proxy connection (conduition)\n\nPull request description:\n\n This PR fixes a bug which excepted initial SOCKS5 proxy connection attempts from the punctual enforcement of timeouts.\n\n Before this change, invoking `Socks5Stream::connect` (or `Socks5Stream::connect_with_password`) could block for much longer than the configured timeout. In practice, this manifested as `Client::from_config` apparently failing to respect the timeout specified in the `Config` passed to it. AFAICT this only applied to SOCKS proxy connections.\n\n ## Example\n\n To demonstrate, here is a simple example program which attempts to connect to an unreachable electrum server with a 10 second timeout.\n ```rust\n use electrum_client::{Client, ConfigBuilder, Socks5Config};\n\n fn main() {\n let proxy = Socks5Config::new(\"127.0.0.1:9050\");\n let config = ConfigBuilder::new()\n .socks5(Some(proxy))\n .timeout(Some(10))\n .build();\n\n let start = std::time::SystemTime::now();\n let result = Client::from_config(\n \"tcp://bejqtnc64qttdempkczylydg7l3ordwugbdar7yqbndck53ukx7wnwad.onion:50001\",\n config,\n );\n match result {\n Ok(_) => {\n println!(\"Successfully connected\")\n }\n Err(e) => {\n println!(\n \"failed to connect after {:.2}s: {e}\",\n start.elapsed().unwrap().as_secs_f64()\n );\n }\n };\n }\n ```\n\n You'd expect the connection attempt to always fail at around 10 seconds, but in fact most attempts take considerably longer.\n\n ```\n $ for i in {1..10} ; do cargo run -q ; done\n failed to connect after 7.65s: host unreachable\n failed to connect after 47.78s: host unreachable\n failed to connect after 18.17s: host unreachable\n failed to connect after 29.24s: host unreachable\n failed to connect after 16.15s: host unreachable\n failed to connect after 14.40s: host unreachable\n failed to connect after 16.89s: host unreachable\n failed to connect after 9.93s: host unreachable\n failed to connect after 8.81s: host unreachable\n failed to connect after 17.80s: host unreachable\n ```\n\n ## Cause and Fix\n\n This was happening because the private method `Socks5Stream::connect_raw` [only respected the `timeout` parameter for _the initial connection to the proxy address_](https://github.com/bitcoindevkit/rust-electrum-client/blob/5ecb26fd7dab552657be511b9c05f7e50cec4cb8/src/socks/v5.rs#L200-L205).\n\n Once that TCP socket is established, the SOCKS5 client code must exchange a couple of messages with the proxy itself: One request/response cycle to authenticate, and then another request/response cycle to configure the forward proxy to the ultimate destination address. The latter of these two request/response cycles could block for long periods of time, in the case where the proxy was responsive but the ultimate destination was unresponsive.\n\n Since no timeout was set on the socket at this stage, the `Socks5Stream` code would wait for an indefinite amount of time for a reply from the proxy, usually only once the proxy itself times out and finally sends a reply.\n\n My suggested fix in this PR is to set the read/write timeouts immediately on the socket connecting to the proxy, so that if the proxy doesn't reply in time, we return an error to the caller promptly.\n\nACKs for top commit:\n RCasatta:\n utACK d8554fb550c87bbbcb3c129b2679a22d5f6dc70b\n\nTree-SHA512: 4bc0ca203465c0d9722680de7251ee49dbea6d5a2b2a833a1ed42e792342a7ac977ad72649603caacd3e58d233b1a516af1ad40c6935addb8165b720d823cf42","shortMessageHtmlLink":"Merge #125: enforce timeout on initial socks5 proxy connection"}},{"before":"e4d2b1d1942771c570b89399d3bdb640694bd914","after":"91228df8a50d7913a22a98c61eaba993acb5e6f6","ref":"refs/heads/master","pushedAt":"2023-12-07T17:27:20.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#121: Upgrade bitcoin\n\ndd3c171a7aa8a90ff1095bd177261e73cb1f70ad Upgrade bitcoin (Tobin C. Harding)\n\nPull request description:\n\n Upgrade bitcoin dependency to `rust-bitcoin v0.31.0-rc1`:\n\n Allows us to remove the dependency on `bitcoin-private` because the `hex` stuff is exposed by `bitcoin` now.\n\nACKs for top commit:\n notmandatory:\n ACK dd3c171a7aa8a90ff1095bd177261e73cb1f70ad\n\nTree-SHA512: 9082d3c2136445230bb23669f83fed58c90d1baf28d35527fc3dea1d40c9d3bdebeddbc44b3bdbc8e79c9b701e09cb453c018af0bc4ac8bcd1c4a14d11c90e39","shortMessageHtmlLink":"Merge #121: Upgrade bitcoin"}},{"before":"dacd772d5ec856731667e4e7b5a71894a622a8c9","after":"e4d2b1d1942771c570b89399d3bdb640694bd914","ref":"refs/heads/master","pushedAt":"2023-12-07T04:55:17.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#122: Add utility to validate `GetMerkleRes`\n\n54fd52d898bd8cfd448a4d303f12c156a7a33201 Add test coverage for `validate_merkle_proof` (Elias Rohrer)\nfe33e19bdabb5da627731c5ca94fac42e7a53882 Add utility for validating a Merkle inclusion proof (Elias Rohrer)\ndd872d67147a2abcae63f4450770f0a0d95c45cb Make response types `Clone` (Elias Rohrer)\n\nPull request description:\n\n I recently needed to validate a Merkle inclusion proof as retrieved via `transaction_get_merkle`.\n\n As I figured it might be useful to other people, too, we add it here as a simple utility method.\n\nACKs for top commit:\n notmandatory:\n ACK 54fd52d898bd8cfd448a4d303f12c156a7a33201\n\nTree-SHA512: aac12160d5b91a011988f45013eb92924c2dfb244c1720e73dc5bcb731e69065c38e022502c756100d8ee6c9af06efa0de9bbfbb2b9e3c2e34d3223539206e1c","shortMessageHtmlLink":"Merge #122: Add utility to validate GetMerkleRes"}},{"before":"8b31e5fe41527907ba1240a328507bd6aec88d05","after":"dacd772d5ec856731667e4e7b5a71894a622a8c9","ref":"refs/heads/master","pushedAt":"2023-12-07T04:53:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#117: Remove `webpki` and bump `webpki-roots` to `v0.25`\n\na331ae80591065fb331c1c1599ff85078b5154a4 Remove `webpki` and bump `webpki-roots` to `v0.25` (Yuki Kishimoto)\n\nPull request description:\n\n I noticed that `webpki` dependency is no longer maintained and that has a high severity vulnerability.\n This PR remove the `webpki` dependency and bump `webpki-roots` to v0.25\n\nACKs for top commit:\n notmandatory:\n ACK a331ae80591065fb331c1c1599ff85078b5154a4\n\nTree-SHA512: 63e9498dc0d56a07e7dd09dd43ca9a924d7e9ebb09934f2c762e64c9ce163cd58edb4d1563db4eba18a0fdf22642cb7d801940baeb97b6ce5473970b739278d4","shortMessageHtmlLink":"Merge #117: Remove webpki and bump webpki-roots to v0.25"}},{"before":"5ecb26fd7dab552657be511b9c05f7e50cec4cb8","after":"8b31e5fe41527907ba1240a328507bd6aec88d05","ref":"refs/heads/master","pushedAt":"2023-12-07T04:45:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"notmandatory","name":"Steve Myers","path":"/notmandatory","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4724730?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#94: Add `Batch::raw` and improve docs\n\nadb0c7444e610570ced1660c1890a5c1fdbd48c8 Add `Batch::raw` and improve docs (志宇)\n\nPull request description:\n\n Being able to add raw requests to `Batch` makes sense from an API standpoint because we already allow raw non-batched requests. This is also useful when the electrum server API gets an updated version and our client is unable to keep up.\n\n Additional to this, I have improved the documentation and made `Call` private (since `Call` is never used externally).\n\nACKs for top commit:\n notmandatory:\n ACK adb0c7444e610570ced1660c1890a5c1fdbd48c8\n\nTree-SHA512: 808dccf1152b750881e45a9709fb4127835ecff3da5ecccffcb9f03e62171192c58154860195db7d3d3467ae8e3e450bba845ff4e8d4dffb302c3d8d6eb837fd","shortMessageHtmlLink":"Merge #94: Add Batch::raw and improve docs"}},{"before":"ed9bb09d02f54a876ff5110c7d2d539c0e2fd57a","after":"5ecb26fd7dab552657be511b9c05f7e50cec4cb8","ref":"refs/heads/master","pushedAt":"2023-08-05T19:28:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#116: Bump to version 0.18\n\n3f6dd0c79621bd31b8f087de3c0346bec1510627 Bump to version 0.18 (Daniela Brozzoni)\n\nPull request description:\n\nACKs for top commit:\n RCasatta:\n ACK 3f6dd0c79621bd31b8f087de3c0346bec1510627\n\nTree-SHA512: f42f2008d79b9a0334c375652842fb2745d2481422a24f27dd4e350bcc17e47f0da2888545a344e1438ede288ed2ad0de8b359b87004fbe059f310aad886c60a","shortMessageHtmlLink":"Merge #116: Bump to version 0.18"}},{"before":"84b1435df52e6e44e9b4e79688548862e63d801f","after":"ed9bb09d02f54a876ff5110c7d2d539c0e2fd57a","ref":"refs/heads/master","pushedAt":"2023-08-03T10:28:12.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#115: Revert \"errors if expecing headers notification but not subscribed\"\n\n2d44350b4445c457ea61f72ba2b42621bc3232b2 Revert \"errors if expecing headers notification but not subscribed\" (Riccardo Casatta)\n\nPull request description:\n\n This reverts commit b86f2bb22c293a5380febd0f1cd2f67a5fd92403.\n\n Some errors started to happen in downstream tests after this commit\n\n #114\n\nACKs for top commit:\n danielabrozzoni:\n utACK 2d44350b4445c457ea61f72ba2b42621bc3232b2\n\nTree-SHA512: d31174055f4245cc9d99f336b166a44271067b8daecaf2bb55d507ecfa4eb557b9802d576742fba59fd4dfda3f45fc76f02d7896af31353f19fc3a38698ac5a2","shortMessageHtmlLink":"Merge #115: Revert \"errors if expecing headers notification but not s…"}},{"before":"87348e58099a43249a777a7b946eb328fdc00fe6","after":"84b1435df52e6e44e9b4e79688548862e63d801f","ref":"refs/heads/master","pushedAt":"2023-07-14T00:52:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#111: Bump to v0.17.0\n\n7535debbd65372e8ec90f7d06ee128ff63545edf Bump to v0.17.0 (Daniela Brozzoni)\n\nPull request description:\n\nACKs for top commit:\n danielabrozzoni:\n self-ACK 7535debbd65372e8ec90f7d06ee128ff63545edf\n\nTree-SHA512: 92292e6d93fcd79fd542b4153cd7689050525bb3834a556cd8e9604307f13ebb4e7012c7c4c9aee0a744046fbf9646e3b05eb93770c49b8252de7f7f2c5debbd","shortMessageHtmlLink":"Merge #111: Bump to v0.17.0"}},{"before":"20493aa475719d0ea7364e86b121117bf32bc5cf","after":"87348e58099a43249a777a7b946eb328fdc00fe6","ref":"refs/heads/master","pushedAt":"2023-07-14T00:48:16.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#112: Ignore other unrecoverable errors in retry client\n\n7c11f208c0e7158e896c3b2821ad395953bb260e Ignore other unrecoverable errors in retry client (Riccardo Casatta)\ndbec56a95b77878220fbba26fbf6ceed07244037 tests: fix list_unspent tests (Riccardo Casatta)\n\nPull request description:\n\n similar to https://github.com/bitcoindevkit/rust-electrum-client/pull/107\n\nACKs for top commit:\n danielabrozzoni:\n utACK 7c11f208c0e7158e896c3b2821ad395953bb260e\n\nTree-SHA512: 74768e197b754dd98bbd435abaa5bbea018e65103615fba0b874252202c59fee5ec07ca90c0a19e112d3a1351e7ac172bef3bdff2eb97d245eb981c2a58660f9","shortMessageHtmlLink":"Merge #112: Ignore other unrecoverable errors in retry client"}},{"before":"c84507e45b47e893b11a56f99cd5f73caaab1aae","after":"20493aa475719d0ea7364e86b121117bf32bc5cf","ref":"refs/heads/master","pushedAt":"2023-06-28T07:47:08.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#110: Update rustls dependency\n\nf5a438cd0a5b68b3f74d3c144e90e2b099c21261 Bump version to 0.16.0 (Tobin C. Harding)\n9a7cc14c94f2587a8a794900dea2ba5665c4aa04 Update rustls dependency to version 0.21 (Tobin C. Harding)\n\nPull request description:\n\n Update the `rustls` dependency to version 0.21 and bump the version of this crate to 0.16 so the change can be released.\n\n I don't know what stage in your release cycle you guys are up to so I put the version bump as a separate patch - can drop it if not needed.\n\n Done to help with https://github.com/bitcoindevkit/rust-esplora-client/pull/51\n\nACKs for top commit:\n danielabrozzoni:\n utACK f5a438cd0a5b68b3f74d3c144e90e2b099c21261\n\nTree-SHA512: 106cbe57651a6e1365f87836598cbec9b1e837f0376ddc1c56cb75e5615543659f5c05cea7d5eb8da8b6cf278fcbe6ef866a019b9829db40cc8055798eb0f541","shortMessageHtmlLink":"Merge #110: Update rustls dependency"}},{"before":"d2dbab93be938135dc8d5b9d70ba7606a877541b","after":"c84507e45b47e893b11a56f99cd5f73caaab1aae","ref":"refs/heads/master","pushedAt":"2023-06-27T13:12:13.727Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#109: Errors if expecting headers notification but not subscribed\n\nb86f2bb22c293a5380febd0f1cd2f67a5fd92403 errors if expecing headers notification but not subscribed (Riccardo Casatta)\n\nPull request description:\n\n the opposite, erroring when subscribing multiple times, is not handled because clients could call multiple times to trigger the server to reply with the tip\n\nACKs for top commit:\n danielabrozzoni:\n utACK b86f2bb22c293a5380febd0f1cd2f67a5fd92403 - changes look good to me, didn't test locally\n\nTree-SHA512: e1a21223448e708cc054271eb1ac5285dc98bdadf7497a856fc4a19ff51655879352ca6ef9f3fb5ec5f9071dd7ee50b2e44d4c65e70694e5d9fa53d280179dd2","shortMessageHtmlLink":"Merge #109: Errors if expecting headers notification but not subscribed"}},{"before":"27eb4d0cb0d95228139dab7a7b4e25ab76e7ee4f","after":"d2dbab93be938135dc8d5b9d70ba7606a877541b","ref":"refs/heads/master","pushedAt":"2023-05-16T15:49:56.010Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#108: Bump to v0.15.1\n\n0f356ef94d3fa6486ebd73d5bd448ec12e070a91 Bump to v0.15.1 (Alekos Filini)\n\nPull request description:\n\n Release as a bug fix with #107 merged\n\nACKs for top commit:\n danielabrozzoni:\n ACK 0f356ef94d3fa6486ebd73d5bd448ec12e070a91\n\nTree-SHA512: 3da6a4701707549d62cfa936f5c185eec0967766797dfbacce1fb68b716b90f7e7e163c797dfb7792435cad2769a43e1b23247b0ec86f9a098a79ea4589ee281","shortMessageHtmlLink":"Merge #108: Bump to v0.15.1"}},{"before":null,"after":"84f11fb80ea77a6998c3d75b2f537bb4b00a743a","ref":"refs/heads/release/0.14.1","pushedAt":"2023-05-15T08:42:25.792Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"afilini","name":"Alekos Filini","path":"/afilini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3058409?s=80&v=4"},"commit":{"message":"Bump to v0.14.1","shortMessageHtmlLink":"Bump to v0.14.1"}},{"before":null,"after":"0f356ef94d3fa6486ebd73d5bd448ec12e070a91","ref":"refs/heads/release/0.15.1","pushedAt":"2023-05-15T08:40:52.253Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"afilini","name":"Alekos Filini","path":"/afilini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3058409?s=80&v=4"},"commit":{"message":"Bump to v0.15.1","shortMessageHtmlLink":"Bump to v0.15.1"}},{"before":"d8ee94c30dbe622d60e0b72e8189c6ef59b5aedb","after":"27eb4d0cb0d95228139dab7a7b4e25ab76e7ee4f","ref":"refs/heads/master","pushedAt":"2023-05-15T08:40:08.337Z","pushType":"push","commitsCount":2,"pusher":{"login":"afilini","name":"Alekos Filini","path":"/afilini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3058409?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#107: Retry client should return AlreadySubscribed error\n\n3a61037733f700c0b03de4069ba055ffbd74254f Retry client should return AlreadySubscribed error (Riccardo Casatta)\n\nPull request description:\n\n Users may leverage the Error to avoid remembering client-side the subscription status. eg. Always subscribing and calling script_pop in case AlreadySubscribed is returned.\n\n Backport for version 0.14.0\n\nACKs for top commit:\n afilini:\n ACK 3a61037733f700c0b03de4069ba055ffbd74254f\n\nTree-SHA512: d6542227ca03b9f3755cec05115f86de54789cfc49fc87b603b653e0458f6b03ae9fea57fa110221395a4e33cf62a5b2bd7639c4269ae5291e4c92c99ef41eba","shortMessageHtmlLink":"Merge #107: Retry client should return AlreadySubscribed error"}},{"before":"b989ddb04b68b19a4613e58b880b588b1c4948a6","after":"d8ee94c30dbe622d60e0b72e8189c6ef59b5aedb","ref":"refs/heads/master","pushedAt":"2023-05-02T18:31:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#105: Bump to v0.15.0\n\nbd16116f9a77779fae249676c1ace67403cd71b0 Bump to v0.15.0 (Alekos Filini)\n\nPull request description:\n\nACKs for top commit:\n danielabrozzoni:\n ACK bd16116f9a77779fae249676c1ace67403cd71b0\n\nTree-SHA512: c184fe6ed2f2b3ad5282b4ddb2d3186dcadee4685a417ebff0f9ab9e1c9a5596d91dc561c831ae7131fc63a0401f4dc29ece30024c09e11b99683f613e8ed856","shortMessageHtmlLink":"Merge #105: Bump to v0.15.0"}},{"before":"abdbd020e1752d9ebf1186327cdc1d1ba5f283e0","after":"b989ddb04b68b19a4613e58b880b588b1c4948a6","ref":"refs/heads/master","pushedAt":"2023-05-02T18:18:56.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielabrozzoni","name":"Daniela Brozzoni","path":"/danielabrozzoni","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25042473?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#103: upgrade bitcoin dep to 0.30.0\n\nc925a9179e6497ed33e8c759bc526d5448be418d upgrade bitcoin dep to 0.30.0 (Riccardo Casatta)\n\nPull request description:\n\nACKs for top commit:\n danielabrozzoni:\n ACK c925a9179e6497ed33e8c759bc526d5448be418d\n\nTree-SHA512: 2b9b7756639af4d931213046866dc36ebee2a5adcbd01c906e27990696b07f1bcf87c2ee009a959f96b17407637801b856e8d4fb9a933fab148f22a619a0d586","shortMessageHtmlLink":"Merge #103: upgrade bitcoin dep to 0.30.0"}},{"before":"a04a84299d5d63444b8e0cff44f3a2229ed86cdb","after":"abdbd020e1752d9ebf1186327cdc1d1ba5f283e0","ref":"refs/heads/master","pushedAt":"2023-04-12T11:55:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"afilini","name":"Alekos Filini","path":"/afilini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3058409?s=80&v=4"},"commit":{"message":"Bump to v0.14.0","shortMessageHtmlLink":"Bump to v0.14.0"}},{"before":"d26dfd7f54be1723e6a7f5d94deb0d5f2a2f350d","after":"a04a84299d5d63444b8e0cff44f3a2229ed86cdb","ref":"refs/heads/master","pushedAt":"2023-04-06T08:09:43.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"afilini","name":"Alekos Filini","path":"/afilini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3058409?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#101: Make ScriptStatus Serializable\n\n80b2adeb4b314261d941f062d310a495c3fe44d2 Make ScriptStatus Serializable (Riccardo Casatta)\n\nPull request description:\n\n it's common to cache this value client side, so making it Serializable simplify things downstream\n\nACKs for top commit:\n afilini:\n ACK 80b2adeb4b314261d941f062d310a495c3fe44d2\n\nTree-SHA512: 9467b4f2ee24ee2a684931df31607135f44c624f65d7d3ee64b3991a06de73a07475e4d1a4b8062093500e6a7cb47c1b2ebf094596fca33bf4cc54b26851b910","shortMessageHtmlLink":"Merge #101: Make ScriptStatus Serializable"}},{"before":"84d6860144a755ea443b04c5a5ad431fc0d4b40d","after":"d26dfd7f54be1723e6a7f5d94deb0d5f2a2f350d","ref":"refs/heads/master","pushedAt":"2023-04-06T08:08:24.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"afilini","name":"Alekos Filini","path":"/afilini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3058409?s=80&v=4"},"commit":{"message":"Merge bitcoindevkit/rust-electrum-client#100: Implement batch call for script subscribe\n\n40cecd5010d9dbda8e5ca883495da44a3ff3e6a8 Use Borrow for all items in IntoIterator (Riccardo Casatta)\nbf2f8ef2e544093ab2e4e31eea9c4b74163e0d33 script_subscribe IntoIterator accepts Borrow<&Script> (Riccardo Casatta)\n156e6fc8397adbb336c7a333a77cd09b3d566927 Implement batch call for script subscribe (Riccardo Casatta)\n\nPull request description:\n\n script_subscribe call hasn't the batch counterpart which may be convenient for multiple subsequent subscribe.\n\nACKs for top commit:\n afilini:\n ACK 40cecd5010d9dbda8e5ca883495da44a3ff3e6a8\n\nTree-SHA512: 26a3ebb9d1267a224c85b765cf793523771bf7e74990dd804a35693bfebc549f7524214725092eac2276f22cd24eafc72270986549ac02f52641db83fcb71324","shortMessageHtmlLink":"Merge #100: Implement batch call for script subscribe"}},{"before":"413c964e5c367f0aea0f4770e1b843808e86766f","after":"84d6860144a755ea443b04c5a5ad431fc0d4b40d","ref":"refs/heads/master","pushedAt":"2023-03-11T11:58:29.453Z","pushType":"push","commitsCount":1,"pusher":{"login":"afilini","name":"Alekos Filini","path":"/afilini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3058409?s=80&v=4"},"commit":{"message":"Bump to v0.13.0","shortMessageHtmlLink":"Bump to v0.13.0"}},{"before":null,"after":"8fae704b7c27e261d228383d6669d02339f3f1aa","ref":"refs/heads/release-0.12.x","pushedAt":"2023-03-11T10:44:36.240Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"afilini","name":"Alekos Filini","path":"/afilini","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3058409?s=80&v=4"},"commit":{"message":"Bump to v0.12.1","shortMessageHtmlLink":"Bump to v0.12.1"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEVf5Z2gA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoindevkit/rust-electrum-client"}