-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More tests for bdk_electrum
fee calculation
#1444
Comments
Correction: not by luck, but because the outpoint is determined to have a vout of 0 and before the fix we're always inserting the first txout. After sleeping on it I think one way to do this is to send a "preliminary" tx to an address in Core's wallet such that the output created becomes the input of the next tx. This preliminary tx is the |
PR #1443 identified a large oversight when we added the new feature of including prev txouts for fee calculation.
I propose a separate test specific to testing fee calculation that takes into account what @ValuedMammal mentioned in #1443 (comment):
Originally posted by @evanlinjin in #1443 (comment)
The text was updated successfully, but these errors were encountered: